Rebased changes to apply VideoOptions per stream.

Rebased changes to apply VideoOptions per stream.

This is work in progress, attempting to rebase the changes in
https://codereview.webrtc.org/1608793004/ on top of recent changes to
SetSendParameters.

BUG=webrtc:5438

[nisse-webrtc, 2016-01-29 10:27:02]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org

[nisse-webrtc, 2016-01-29 10:27:03]

I think I need a little help to get this right, it's not entirely clear to me
how SetSendParameters is intended to work.

The current code fails two tests,

  WebRtcVideoChannel2Test.DoesNotAdaptOnOveruseWhenDisabled
  WebRtcVideoChannel2Test.TestSetDscpOptions

I'm thinking that maybe it's best to do the refactoring to take out
construction-time options first, and then get back to these changes.

[pbos-webrtc, 2016-01-29 10:31:37]

On 2016/01/29 10:27:03, nisse-webrtc wrote:
> I think I need a little help to get this right, it's not entirely clear to me
> how SetSendParameters is intended to work.
> 
> The current code fails two tests,
> 
>   WebRtcVideoChannel2Test.DoesNotAdaptOnOveruseWhenDisabled
>   WebRtcVideoChannel2Test.TestSetDscpOptions
> 
> I'm thinking that maybe it's best to do the refactoring to take out
> construction-time options first, and then get back to these changes.

I think so too, both of these should be construction time and not inside
VideoOptions imo.

[pbos-webrtc, 2016-01-29 10:32:21]

On 2016/01/29 10:31:37, pbos-webrtc wrote:
> On 2016/01/29 10:27:03, nisse-webrtc wrote:
> > I think I need a little help to get this right, it's not entirely clear to
me
> > how SetSendParameters is intended to work.
> > 
> > The current code fails two tests,
> > 
> >   WebRtcVideoChannel2Test.DoesNotAdaptOnOveruseWhenDisabled
> >   WebRtcVideoChannel2Test.TestSetDscpOptions
> > 
> > I'm thinking that maybe it's best to do the refactoring to take out
> > construction-time options first, and then get back to these changes.
> 
> I think so too, both of these should be construction time and not inside
> VideoOptions imo.

As well as the disable_prerender_smoothing or whatever that one was called, e.g.
anything from RTCConfiguration should be const on construction I think.

[nisse-webrtc, 2016-02-12 09:15:24]

Description was changed from

==========
Rebased changes to apply VideoOptions per stream.

This is work in progress, attempting to rebase the changes in
https://codereview.webrtc.org/1608793004/ on top of recent changes to
SetSendParameters.

BUG=webrtc:5438
==========

to

==========
Rebased changes to apply VideoOptions per stream.

This is work in progress, attempting to rebase the changes in
https://codereview.webrtc.org/1608793004/ on top of recent changes to
SetSendParameters.

BUG=webrtc:5438
==========

[nisse-webrtc, 2016-02-12 09:15:24]

nisse@webrtc.org changed reviewers:
- pbos@webrtc.org