Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: talk/app/webrtc/videosource.h

Issue 1646463002: Revert of New rtc::VideoSinkInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/rtpsenderreceiver_unittest.cc ('k') | talk/app/webrtc/videosource.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 20 matching lines...) Expand all
31 #include <list> 31 #include <list>
32 32
33 #include "talk/app/webrtc/mediastreaminterface.h" 33 #include "talk/app/webrtc/mediastreaminterface.h"
34 #include "talk/app/webrtc/notifier.h" 34 #include "talk/app/webrtc/notifier.h"
35 #include "talk/app/webrtc/videosourceinterface.h" 35 #include "talk/app/webrtc/videosourceinterface.h"
36 #include "talk/app/webrtc/videotrackrenderers.h" 36 #include "talk/app/webrtc/videotrackrenderers.h"
37 #include "talk/media/base/videocapturer.h" 37 #include "talk/media/base/videocapturer.h"
38 #include "talk/media/base/videocommon.h" 38 #include "talk/media/base/videocommon.h"
39 #include "webrtc/base/scoped_ptr.h" 39 #include "webrtc/base/scoped_ptr.h"
40 #include "webrtc/base/sigslot.h" 40 #include "webrtc/base/sigslot.h"
41 #include "webrtc/media/base/videosinkinterface.h"
42 41
43 // VideoSource implements VideoSourceInterface. It owns a 42 // VideoSource implements VideoSourceInterface. It owns a
44 // cricket::VideoCapturer and make sure the camera is started at a resolution 43 // cricket::VideoCapturer and make sure the camera is started at a resolution
45 // that honors the constraints. 44 // that honors the constraints.
46 // The state is set depending on the result of starting the capturer. 45 // The state is set depending on the result of starting the capturer.
47 // If the constraint can't be met or the capturer fails to start, the state 46 // If the constraint can't be met or the capturer fails to start, the state
48 // transition to kEnded, otherwise it transitions to kLive. 47 // transition to kEnded, otherwise it transitions to kLive.
49 48
50 namespace cricket { 49 namespace cricket {
51 50
(...skipping 26 matching lines...) Expand all
78 77
79 virtual cricket::VideoCapturer* GetVideoCapturer() { 78 virtual cricket::VideoCapturer* GetVideoCapturer() {
80 return video_capturer_.get(); 79 return video_capturer_.get();
81 } 80 }
82 81
83 void Stop() override; 82 void Stop() override;
84 void Restart() override; 83 void Restart() override;
85 84
86 // |output| will be served video frames as long as the underlying capturer 85 // |output| will be served video frames as long as the underlying capturer
87 // is running video frames. 86 // is running video frames.
88 virtual void AddSink(rtc::VideoSinkInterface<cricket::VideoFrame>* output); 87 virtual void AddSink(cricket::VideoRenderer* output);
89 virtual void RemoveSink(rtc::VideoSinkInterface<cricket::VideoFrame>* output); 88 virtual void RemoveSink(cricket::VideoRenderer* output);
90 89
91 protected: 90 protected:
92 VideoSource(cricket::ChannelManager* channel_manager, 91 VideoSource(cricket::ChannelManager* channel_manager,
93 cricket::VideoCapturer* capturer, 92 cricket::VideoCapturer* capturer,
94 bool remote); 93 bool remote);
95 virtual ~VideoSource(); 94 virtual ~VideoSource();
96 void Initialize(const webrtc::MediaConstraintsInterface* constraints); 95 void Initialize(const webrtc::MediaConstraintsInterface* constraints);
97 96
98 private: 97 private:
99 void OnStateChange(cricket::VideoCapturer* capturer, 98 void OnStateChange(cricket::VideoCapturer* capturer,
100 cricket::CaptureState capture_state); 99 cricket::CaptureState capture_state);
101 void SetState(SourceState new_state); 100 void SetState(SourceState new_state);
102 101
103 cricket::ChannelManager* channel_manager_; 102 cricket::ChannelManager* channel_manager_;
104 rtc::scoped_ptr<cricket::VideoCapturer> video_capturer_; 103 rtc::scoped_ptr<cricket::VideoCapturer> video_capturer_;
105 rtc::scoped_ptr<cricket::VideoRenderer> frame_input_; 104 rtc::scoped_ptr<cricket::VideoRenderer> frame_input_;
106 105
107 std::list<rtc::VideoSinkInterface<cricket::VideoFrame>*> sinks_; 106 std::list<cricket::VideoRenderer*> sinks_;
108 107
109 cricket::VideoFormat format_; 108 cricket::VideoFormat format_;
110 cricket::VideoOptions options_; 109 cricket::VideoOptions options_;
111 SourceState state_; 110 SourceState state_;
112 const bool remote_; 111 const bool remote_;
113 }; 112 };
114 113
115 } // namespace webrtc 114 } // namespace webrtc
116 115
117 #endif // TALK_APP_WEBRTC_VIDEOSOURCE_H_ 116 #endif // TALK_APP_WEBRTC_VIDEOSOURCE_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/rtpsenderreceiver_unittest.cc ('k') | talk/app/webrtc/videosource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698