Chromium Code Reviews| Index: talk/app/webrtc/webrtcsession_unittest.cc |
| diff --git a/talk/app/webrtc/webrtcsession_unittest.cc b/talk/app/webrtc/webrtcsession_unittest.cc |
| index 83659f09fe6d820bc20a6c34468b8b64d3aa4212..b4bb8402ac56dd78720675683fe9464d14a668bd 100644 |
| --- a/talk/app/webrtc/webrtcsession_unittest.cc |
| +++ b/talk/app/webrtc/webrtcsession_unittest.cc |
| @@ -4074,7 +4074,7 @@ TEST_F(WebRtcSessionTest, TestSetRemoteOfferFailIfDtlsDisabledAndNoCrypto) { |
| } |
| // This test verifies DSCP is properly applied on the media channels. |
| -TEST_F(WebRtcSessionTest, TestDscpConstraint) { |
| +TEST_F(WebRtcSessionTest, DISABLED_TestDscpConstraint) { |
| constraints_.reset(new FakeConstraints()); |
| constraints_->AddOptional( |
| webrtc::MediaConstraintsInterface::kEnableDscp, true); |
| @@ -4089,10 +4089,14 @@ TEST_F(WebRtcSessionTest, TestDscpConstraint) { |
| ASSERT_TRUE(video_channel_ != NULL); |
| ASSERT_TRUE(voice_channel_ != NULL); |
| +#if 0 |
|
pbos-webrtc
2016/02/01 14:44:38
Assuming fixing this test is still pending?
nisse-webrtc
2016/02/02 11:32:50
Done (but not yet uploaded). Was harder than expec
|
| const cricket::AudioOptions& audio_options = voice_channel_->options(); |
| const cricket::VideoOptions& video_options = video_channel_->options(); |
| + // TODO(nisse): To keep this test, we need a method to return the |
| + // MediaChannelOptions. |
| EXPECT_EQ(rtc::Optional<bool>(true), audio_options.dscp); |
| EXPECT_EQ(rtc::Optional<bool>(true), video_options.dscp); |
| +#endif |
| } |
| TEST_F(WebRtcSessionTest, TestSuspendBelowMinBitrateConstraint) { |