Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: talk/session/media/channelmanager_unittest.cc

Issue 1646253004: Split out dscp option from VideoOptions to new struct MediaChannelOptions. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/session/media/channelmanager.cc ('k') | webrtc/media/base/fakemediaengine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/session/media/channelmanager_unittest.cc
diff --git a/talk/session/media/channelmanager_unittest.cc b/talk/session/media/channelmanager_unittest.cc
index 81faad4eb45552c75625dc8f5a4dbc485e61e5fd..de594886d84bd2e68b79c57473a3a3f3e9f561e5 100644
--- a/talk/session/media/channelmanager_unittest.cc
+++ b/talk/session/media/channelmanager_unittest.cc
@@ -119,11 +119,13 @@ TEST_F(ChannelManagerTest, CreateDestroyChannels) {
EXPECT_TRUE(cm_->Init());
cricket::VoiceChannel* voice_channel =
cm_->CreateVoiceChannel(&fake_mc_, transport_controller_,
- cricket::CN_AUDIO, false, AudioOptions());
+ cricket::CN_AUDIO, false,
+ MediaChannelOptions(), AudioOptions());
EXPECT_TRUE(voice_channel != nullptr);
cricket::VideoChannel* video_channel =
cm_->CreateVideoChannel(&fake_mc_, transport_controller_,
- cricket::CN_VIDEO, false, VideoOptions());
+ cricket::CN_VIDEO, false,
+ MediaChannelOptions(), VideoOptions());
EXPECT_TRUE(video_channel != nullptr);
cricket::DataChannel* data_channel = cm_->CreateDataChannel(
transport_controller_, cricket::CN_DATA, false, cricket::DCT_RTP);
@@ -144,11 +146,13 @@ TEST_F(ChannelManagerTest, CreateDestroyChannelsOnThread) {
new cricket::FakeTransportController(&worker_, ICEROLE_CONTROLLING);
cricket::VoiceChannel* voice_channel =
cm_->CreateVoiceChannel(&fake_mc_, transport_controller_,
- cricket::CN_AUDIO, false, AudioOptions());
+ cricket::CN_AUDIO, false,
+ MediaChannelOptions(), AudioOptions());
EXPECT_TRUE(voice_channel != nullptr);
cricket::VideoChannel* video_channel =
cm_->CreateVideoChannel(&fake_mc_, transport_controller_,
- cricket::CN_VIDEO, false, VideoOptions());
+ cricket::CN_VIDEO, false,
+ MediaChannelOptions(), VideoOptions());
EXPECT_TRUE(video_channel != nullptr);
cricket::DataChannel* data_channel = cm_->CreateDataChannel(
transport_controller_, cricket::CN_DATA, false, cricket::DCT_RTP);
@@ -171,11 +175,13 @@ TEST_F(ChannelManagerTest, NoTransportChannelTest) {
cricket::VoiceChannel* voice_channel =
cm_->CreateVoiceChannel(&fake_mc_, transport_controller_,
- cricket::CN_AUDIO, false, AudioOptions());
+ cricket::CN_AUDIO, false,
+ MediaChannelOptions(), AudioOptions());
EXPECT_TRUE(voice_channel == nullptr);
cricket::VideoChannel* video_channel =
cm_->CreateVideoChannel(&fake_mc_, transport_controller_,
- cricket::CN_VIDEO, false, VideoOptions());
+ cricket::CN_VIDEO, false,
+ MediaChannelOptions(), VideoOptions());
EXPECT_TRUE(video_channel == nullptr);
cricket::DataChannel* data_channel = cm_->CreateDataChannel(
transport_controller_, cricket::CN_DATA, false, cricket::DCT_RTP);
« no previous file with comments | « talk/session/media/channelmanager.cc ('k') | webrtc/media/base/fakemediaengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698