Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: talk/app/webrtc/webrtcsession_unittest.cc

Issue 1646253004: Split out dscp option from VideoOptions to new struct MediaChannelOptions. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/app/webrtc/webrtcsession.cc ('k') | talk/session/media/channel_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/webrtcsession_unittest.cc
diff --git a/talk/app/webrtc/webrtcsession_unittest.cc b/talk/app/webrtc/webrtcsession_unittest.cc
index c553165f9b57f523e965d3d82efbee3fb37461b2..6ed2bfaac3ec701a5695f6aa273ae83b8e89ebf6 100644
--- a/talk/app/webrtc/webrtcsession_unittest.cc
+++ b/talk/app/webrtc/webrtcsession_unittest.cc
@@ -57,6 +57,7 @@
#include "webrtc/base/thread.h"
#include "webrtc/base/virtualsocketserver.h"
#include "webrtc/media/base/fakemediaengine.h"
+#include "webrtc/media/base/fakenetworkinterface.h"
#include "webrtc/media/base/fakevideorenderer.h"
#include "webrtc/media/base/mediachannel.h"
#include "webrtc/media/webrtc/fakewebrtccall.h"
@@ -4089,10 +4090,15 @@ TEST_F(WebRtcSessionTest, TestDscpConstraint) {
ASSERT_TRUE(video_channel_ != NULL);
ASSERT_TRUE(voice_channel_ != NULL);
- const cricket::AudioOptions& audio_options = voice_channel_->options();
- const cricket::VideoOptions& video_options = video_channel_->options();
- EXPECT_EQ(rtc::Optional<bool>(true), audio_options.dscp);
- EXPECT_EQ(rtc::Optional<bool>(true), video_options.dscp);
+
+ cricket::FakeNetworkInterface video_network_interface;
+ cricket::FakeNetworkInterface voice_network_interface;
+ video_channel_->SetInterface(&video_network_interface);
+ voice_channel_->SetInterface(&voice_network_interface);
+ EXPECT_EQ(rtc::DSCP_AF41, video_network_interface.dscp());
+ EXPECT_EQ(rtc::DSCP_EF, voice_network_interface.dscp());
+ video_channel_->SetInterface(NULL);
+ voice_channel_->SetInterface(NULL);
}
TEST_F(WebRtcSessionTest, TestSuspendBelowMinBitrateConstraint) {
« no previous file with comments | « talk/app/webrtc/webrtcsession.cc ('k') | talk/session/media/channel_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698