Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.h

Issue 1645543003: H264: Improve FFmpeg decoder performance by using I420BufferPool. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added comments about why we zero-initialize Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.h
diff --git a/webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.h b/webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.h
index f5924fccc1d15e8b505919f4569b024d3e85087e..c475a36f22f9fa9afe8f60c55a1ab137d0945e04 100644
--- a/webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.h
+++ b/webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.h
@@ -19,6 +19,7 @@ extern "C" {
} // extern "C"
#include "webrtc/base/scoped_ptr.h"
+#include "webrtc/common_video/include/i420_buffer_pool.h"
namespace webrtc {
@@ -52,8 +53,13 @@ class H264DecoderImpl : public H264Decoder {
int64_t render_time_ms = -1) override;
private:
+ static int AVGetBuffer2(
stefan-webrtc 2016/02/01 14:02:09 Add a comment describing what these implement.
hbos 2016/02/02 16:13:03 Done.
+ AVCodecContext* context, AVFrame* av_frame, int flags);
+ static void AVFreeBuffer2(void* opaque, uint8_t* data);
+
bool IsInitialized() const;
+ I420BufferPool pool_;
rtc::scoped_ptr<AVCodecContext, AVCodecContextDeleter> av_context_;
rtc::scoped_ptr<AVFrame, AVFrameDeleter> av_frame_;

Powered by Google App Engine
This is Rietveld 408576698