webrtc/common_video/include/video_frame_buffer.h - Issue 1645543003: H264: Improve FFmpeg decoder performance by using I420BufferPool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_video/include/video_frame_buffer.h

Issue 1645543003: H264: Improve FFmpeg decoder performance by using I420BufferPool. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added comments about why we zero-initialize Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/common_video/include/i420_buffer_pool.h ('K') | « webrtc/common_video/include/i420_buffer_pool.h ('k') | webrtc/common_video/video_frame_buffer.cc » ('j') | webrtc/common_video/video_frame_buffer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/common_video/include/video_frame_buffer.h

diff --git a/webrtc/common_video/include/video_frame_buffer.h b/webrtc/common_video/include/video_frame_buffer.h

index 710d2862f0b9a37c88bf72898c24c80d60d52648..1950bb7845887b8b4ca75c342609e79b1dea5745 100644

--- a/webrtc/common_video/include/video_frame_buffer.h

+++ b/webrtc/common_video/include/video_frame_buffer.h

@@ -73,6 +73,8 @@ class I420Buffer : public VideoFrameBuffer {

// Non-const data access is only allowed if HasOneRef() is true to protect

// against unexpected overwrites.

uint8_t* MutableData(PlaneType type) override;

+ // The size of the |data| buffer.

+ size_t DataSize() const;

int stride(PlaneType type) const override;

void* native_handle() const override;

rtc::scoped_refptr<VideoFrameBuffer> NativeToI420Buffer() override;