Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: webrtc/base/macwindowpicker.cc

Issue 1644843003: Compile rtc_base_objc and rtc_api_objc for Mac (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add references to issues Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/macwindowpicker.cc
diff --git a/webrtc/base/macwindowpicker.cc b/webrtc/base/macwindowpicker.cc
index bb97d20f1ac493caceab92eca813b5558a0931bf..c61fa29d6555d8c127e436fe4bc8872235f82a47 100644
--- a/webrtc/base/macwindowpicker.cc
+++ b/webrtc/base/macwindowpicker.cc
@@ -160,6 +160,9 @@ bool MacWindowPicker::MoveToFront(const WindowId& id) {
// to front might be behind another X application.
ProcessSerialNumber psn;
pid_t pid = pid_val;
+// TODO(5478): Update deprecated APIs.
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated"
int res = GetProcessForPID(pid, &psn);
if (res != 0) {
LOG(LS_ERROR) << "Failed getting process for pid";
@@ -170,6 +173,7 @@ bool MacWindowPicker::MoveToFront(const WindowId& id) {
LOG(LS_ERROR) << "Failed setting process to front";
result = false;
}
+#pragma clang diagnostic pop
}
CFRelease(window_id_array);
CFRelease(window_array);

Powered by Google App Engine
This is Rietveld 408576698