Compile rtc_base_objc and rtc_api_objc for Mac

webrtc/api/BUILD.gn

Index: webrtc/api/BUILD.gn
diff --git a/webrtc/api/BUILD.gn b/webrtc/api/BUILD.gn
index 3f47ac811573b0b61ae662762477a5ff0f19254a..bfa4e20aba695952e676364c6c7ab62297857234 100644
--- a/webrtc/api/BUILD.gn
+++ b/webrtc/api/BUILD.gn
@@ -17,7 +17,7 @@ config("ios_config") {
   ]
 }
 
-if (is_ios) {
+if (is_ios || is_mac) {
   source_set("rtc_api_objc") {
     deps = [
       "//webrtc/base:rtc_base_objc",
@@ -29,9 +29,6 @@ if (is_ios) {
     ]
     sources = [
       # Add these when there's a BUILD.gn for peer connection APIs
-      #"objc/RTCAVFoundationVideoSource+Private.h",
-      #"objc/RTCAVFoundationVideoSource.h",
-      #"objc/RTCAVFoundationVideoSource.mm",
       #"objc/RTCAudioTrack+Private.h",
       #"objc/RTCAudioTrack.h",
       #"objc/RTCAudioTrack.mm",
@@ -62,6 +59,8 @@ if (is_ios) {
       #"objc/RTCVideoTrack+Private.h",
       #"objc/RTCVideoTrack.h",
       #"objc/RTCVideoTrack.mm",
+      # TODO(5477): Fix prefix headers.

[kjellander_webrtc, 2016/02/01 06:08:29]

The format of TODOs is generally TODO(username), so please make this something
like:
TODO(hjon): Fix prefix headers (see webrtc:5477 for details).

[hjon_webrtc, 2016/02/02 23:03:50]

Done.

+      "../build/WebRTC-Prefix.pch",
       "objc/RTCIceServer+Private.h",
       "objc/RTCIceServer.h",
       "objc/RTCIceServer.mm",
@@ -83,15 +82,18 @@ if (is_ios) {
       "objc/RTCVideoRendererAdapter+Private.h",
       "objc/RTCVideoRendererAdapter.h",
       "objc/RTCVideoRendererAdapter.mm",
-      "objc/WebRTC-Prefix.pch",
-      "objc/avfoundationvideocapturer.h",
-      "objc/avfoundationvideocapturer.mm",
     ]
 
     if (is_ios) {
       sources += [
+        # Add these when there's a BUILD.gn for peer connection APIs
+        #"objc/RTCAVFoundationVideoSource+Private.h",
+        #"objc/RTCAVFoundationVideoSource.h",
+        #"objc/RTCAVFoundationVideoSource.mm",
         "objc/RTCEAGLVideoView.h",
         "objc/RTCEAGLVideoView.m",
+        "objc/avfoundationvideocapturer.h",

[kjellander_webrtc, 2016/02/01 06:08:29]

So we can't add these for Desktop Mac? AVFoundation has been available since
10.7 so since we require 10.10, shouldn't it also work for is_mac?

[tkchin_webrtc, 2016/02/02 10:04:46]

I never tested them for Desktop Mac. Afaik I'm using iOS specific capture modes.
It should work with minor modification though.

[kjellander_webrtc, 2016/02/02 20:20:11]

I see, I was just wondering (I didn't look in the source code). Let's not worry
about that in this CL then (possibly future improvement).

+        "objc/avfoundationvideocapturer.mm",
       ]
     }