webrtc/build/objc_common.gypi - Issue 1644843003: Compile rtc_base_objc and rtc_api_objc for Mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/build/objc_common.gypi

Issue 1644843003: Compile rtc_base_objc and rtc_api_objc for Mac (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Add references to issues Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2015 The WebRTC project authors. All Rights Reserved.
	kjellander_webrtc 2016/02/01 06:08:29 I guess this should be 2016 now. I guess this should be 2016 now. hjon_webrtc 2016/02/02 23:03:50 Should I just go ahead and change this in all of t Show quoted text On 2016/02/01 06:08:29, kjellander (webrtc) wrote: > I guess this should be 2016 now. Should I just go ahead and change this in all of the files I touched or is there a preferred way to maintain consistency across different directories? kjellander_webrtc 2016/02/03 07:57:33 No it only applies to newly added files, luckily. Show quoted text On 2016/02/02 23:03:50, hjon_webrtc wrote: > On 2016/02/01 06:08:29, kjellander (webrtc) wrote: > > I guess this should be 2016 now. > > Should I just go ahead and change this in all of the files I touched or is there > a preferred way to maintain consistency across different directories? No it only applies to newly added files, luckily. So this one is the only one affected (since WebRTC-Prefix.pch was moved). See http://dev.chromium.org/developers/coding-style#TOC-File-headers for more info. hjon_webrtc 2016/02/04 01:43:03 Done. Show quoted text On 2016/02/03 07:57:33, kjellander (webrtc) wrote: > On 2016/02/02 23:03:50, hjon_webrtc wrote: > > On 2016/02/01 06:08:29, kjellander (webrtc) wrote: > > > I guess this should be 2016 now. > > > > Should I just go ahead and change this in all of the files I touched or is > there > > a preferred way to maintain consistency across different directories? > > No it only applies to newly added files, luckily. So this one is the only one > affected (since WebRTC-Prefix.pch was moved). See > http://dev.chromium.org/developers/coding-style#TOC-File-headers for more info. Done.
	2 #

	3 # Use of this source code is governed by a BSD-style license

	4 # that can be found in the LICENSE file in the root of the source

	5 # tree. An additional intellectual property rights grant can be found

	6 # in the file PATENTS. All contributing project authors may

	7 # be found in the AUTHORS file in the root of the source tree.

	8

	9 # ObjC target common prefix header.

	10

	11 {

	12 'variables': {

	13 'objc_prefix_file': './WebRTC-Prefix.pch',

	14 },

	15 'xcode_settings': {

	16 'CLANG_ENABLE_OBJC_ARC': 'YES',

	17 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES',

	18 'GCC_PREFIX_HEADER': '<(objc_prefix_file)',

	19 'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'

	20 },

	21 }

OLD	NEW

« webrtc/base/logging.cc ('K') | « webrtc/build/WebRTC-Prefix.pch ('k') | webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit_info_objc.mm » ('j') | webrtc/supplement.gypi » ('J')