Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 1644253003: Add option to disable particular HW video codec from app. (Closed)

Created:
4 years, 10 months ago by AlexG
Modified:
4 years, 10 months ago
Reviewers:
jiayl2
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add option to disable particular HW video codec from app. Plus minor clean up / adding comments. BUG=b/26695339 R=jiayl@webrtc.org Committed: https://crrev.com/eee86a6aa3c172e079a451d05c0e17001e3bb4af Cr-Commit-Position: refs/heads/master@{#11431}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -64 lines) Patch
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java View 10 chunks +71 lines, -36 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java View 5 chunks +52 lines, -28 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
AlexG
PTAL
4 years, 10 months ago (2016-01-29 19:32:11 UTC) #2
jiayl2
https://codereview.webrtc.org/1644253003/diff/1/talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java (right): https://codereview.webrtc.org/1644253003/diff/1/talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java#newcode146 talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java:146: public static void disableVp8HwCodec() { When should these methods ...
4 years, 10 months ago (2016-01-29 20:37:38 UTC) #3
AlexG
On 2016/01/29 20:37:38, jiayl2 wrote: > https://codereview.webrtc.org/1644253003/diff/1/talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java > File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java (right): > > https://codereview.webrtc.org/1644253003/diff/1/talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java#newcode146 > ...
4 years, 10 months ago (2016-01-29 20:39:49 UTC) #4
jiayl2
lgtm
4 years, 10 months ago (2016-01-29 21:11:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644253003/1
4 years, 10 months ago (2016-01-29 21:12:38 UTC) #7
AlexG
Committed patchset #1 (id:1) manually as eee86a6aa3c172e079a451d05c0e17001e3bb4af (presubmit successful).
4 years, 10 months ago (2016-01-29 22:17:20 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 22:17:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eee86a6aa3c172e079a451d05c0e17001e3bb4af
Cr-Commit-Position: refs/heads/master@{#11431}

Powered by Google App Engine
This is Rietveld 408576698