Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1642903002: Prevent division-by-zero in VCMFecMethod. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Prevent division-by-zero in VCMFecMethod. Clamps frameRate to at least 1.0 to prevent a zero division. BUG=webrtc:5124 R=stefan@webrtc.org Committed: https://crrev.com/5e8351b325bb8a4bdabccea8b66626b6639d5f96 Cr-Commit-Position: refs/heads/master@{#11421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/video_coding/media_opt_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL woo
4 years, 10 months ago (2016-01-28 13:17:19 UTC) #1
stefan-webrtc
lgtm
4 years, 10 months ago (2016-01-28 19:33:52 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as 5e8351b325bb8a4bdabccea8b66626b6639d5f96 (presubmit successful).
4 years, 10 months ago (2016-01-28 22:55:50 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 22:55:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e8351b325bb8a4bdabccea8b66626b6639d5f96
Cr-Commit-Position: refs/heads/master@{#11421}

Powered by Google App Engine
This is Rietveld 408576698