Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 1642733002: Removing "candidates" attribute from TransportDescription. (Closed)

Created:
4 years, 11 months ago by Taylor Brandstetter
Modified:
4 years, 10 months ago
Reviewers:
honghaiz3, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing "candidates" attribute from TransportDescription. It's never used anywhere, so it only causes confusion between itself and SessionDescriptionInterface::candidates. Committed: https://crrev.com/46eed76207acd11ae3d07681531decf819d3ef49 Cr-Commit-Position: refs/heads/master@{#11420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -101 lines) Patch
M talk/app/webrtc/jsepsessiondescription_unittest.cc View 1 chunk +10 lines, -17 lines 0 comments Download
M talk/app/webrtc/webrtcsdp.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M talk/app/webrtc/webrtcsdp_unittest.cc View 2 chunks +10 lines, -30 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/p2p/base/transport_unittest.cc View 4 chunks +6 lines, -11 lines 0 comments Download
M webrtc/p2p/base/transportcontroller_unittest.cc View 5 chunks +18 lines, -18 lines 0 comments Download
M webrtc/p2p/base/transportdescription.h View 6 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Taylor Brandstetter
4 years, 11 months ago (2016-01-27 20:09:38 UTC) #2
pthatcher1
lgtm
4 years, 11 months ago (2016-01-27 21:19:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642733002/1
4 years, 10 months ago (2016-01-28 19:40:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 21:24:41 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 21:25:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46eed76207acd11ae3d07681531decf819d3ef49
Cr-Commit-Position: refs/heads/master@{#11420}

Powered by Google App Engine
This is Rietveld 408576698