Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: talk/app/webrtc/webrtcsession_unittest.cc

Issue 1642513002: Delete unused members from VideoOptions (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Suggested comment edits. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/app/webrtc/webrtcsession.cc ('k') | talk/media/base/constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/webrtcsession_unittest.cc
diff --git a/talk/app/webrtc/webrtcsession_unittest.cc b/talk/app/webrtc/webrtcsession_unittest.cc
index 5f4856dc610e1ff08460dbda4e05984214f0382d..83659f09fe6d820bc20a6c34468b8b64d3aa4212 100644
--- a/talk/app/webrtc/webrtcsession_unittest.cc
+++ b/talk/app/webrtc/webrtcsession_unittest.cc
@@ -764,27 +764,6 @@ class WebRtcSessionTest
VerifyCryptoParams(answer->description());
}
- void SetAndVerifyNumUnsignalledRecvStreams(
- int value_set, int value_expected) {
- constraints_.reset(new FakeConstraints());
- constraints_->AddOptional(
- webrtc::MediaConstraintsInterface::kNumUnsignalledRecvStreams,
- value_set);
- session_.reset();
- Init();
- SendAudioVideoStream1();
- SessionDescriptionInterface* offer = CreateOffer();
-
- SetLocalDescriptionWithoutError(offer);
-
- video_channel_ = media_engine_->GetVideoChannel(0);
-
- ASSERT_TRUE(video_channel_ != NULL);
- const cricket::VideoOptions& video_options = video_channel_->options();
- EXPECT_EQ(value_expected,
- video_options.unsignalled_recv_stream_limit.value_or(-1));
- }
-
void CompareIceUfragAndPassword(const cricket::SessionDescription* desc1,
const cricket::SessionDescription* desc2,
bool expect_equal) {
@@ -4134,15 +4113,6 @@ TEST_F(WebRtcSessionTest, TestSuspendBelowMinBitrateConstraint) {
EXPECT_EQ(rtc::Optional<bool>(true), video_options.suspend_below_min_bitrate);
}
-TEST_F(WebRtcSessionTest, TestNumUnsignalledRecvStreamsConstraint) {
- // Number of unsignalled receiving streams should be between 0 and
- // kMaxUnsignalledRecvStreams.
- SetAndVerifyNumUnsignalledRecvStreams(10, 10);
- SetAndVerifyNumUnsignalledRecvStreams(kMaxUnsignalledRecvStreams + 1,
- kMaxUnsignalledRecvStreams);
- SetAndVerifyNumUnsignalledRecvStreams(-1, 0);
-}
-
TEST_F(WebRtcSessionTest, TestCombinedAudioVideoBweConstraint) {
constraints_.reset(new FakeConstraints());
constraints_->AddOptional(
« no previous file with comments | « talk/app/webrtc/webrtcsession.cc ('k') | talk/media/base/constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698