Consolidate setters into SetRecvParameters.

Consolidate setters into SetRecvParameters.

Merges SetRecvCodec/SetRecvExtensions and an extra call for changing
RTCP mode, resulting in recreating the stream at most once instead of up
to three times.

BUG=webrtc:5296
R=deadbeef@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/378dc770a6e3c80105ae9b9729855439c8732d80
Cr-Commit-Position: refs/heads/master@{#11422}

[pbos-webrtc, 2016-01-28 16:40:50]

Description was changed from

==========
Consolidate setters into SetRecvParameters.

Merges SetRecvCodec/SetRecvExtensions and an extra call for changing
RTCP mode, resulting in recreating the stream up to once instead of
three times.

BUG=webrtc:5296
R=deadbeef@webrtc.org, pthatcher@webrtc.org
==========

to

==========
Consolidate setters into SetRecvParameters.

Merges SetRecvCodec/SetRecvExtensions and an extra call for changing
RTCP mode, resulting in recreating the stream at most once instead of up
to three times.

BUG=webrtc:5296
R=deadbeef@webrtc.org, pthatcher@webrtc.org
==========

[pbos-webrtc, 2016-01-28 16:40:56]

PTAL

[pthatcher1, 2016-01-28 18:41:53]

lgtm

[Taylor Brandstetter, 2016-01-28 18:57:21]

lgtm, just one small question.

https://codereview.webrtc.org/1641863004/diff/1/talk/media/webrtc/webrtcvideo...
File talk/media/webrtc/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1641863004/diff/1/talk/media/webrtc/webrtcvideo...
talk/media/webrtc/webrtcvideoengine2.cc:657: default_send_ssrc_ = 0;
ValidateCodecFormats is no longer called here, is that ok?

[pbos-webrtc, 2016-01-28 22:58:42]

dcheck

[pbos-webrtc, 2016-01-28 22:58:43]

https://codereview.webrtc.org/1641863004/diff/1/talk/media/webrtc/webrtcvideo...
File talk/media/webrtc/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1641863004/diff/1/talk/media/webrtc/webrtcvideo...
talk/media/webrtc/webrtcvideoengine2.cc:657: default_send_ssrc_ = 0;
On 2016/01/28 18:57:21, Taylor Brandstetter wrote:
> ValidateCodecFormats is no longer called here, is that ok?

Added a DCHECK, this shouldn't be externally controlled.

[pbos-webrtc, 2016-01-28 22:58:51]

The CQ bit was checked by pbos@webrtc.org

[pbos-webrtc, 2016-01-28 22:58:52]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1641863004/#ps20001 (title:
"dcheck")

[commit-bot: I haz the power, 2016-01-28 22:59:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641863004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641863004/20001

[commit-bot: I haz the power, 2016-01-28 23:58:45]

Description was changed from

==========
Consolidate setters into SetRecvParameters.

Merges SetRecvCodec/SetRecvExtensions and an extra call for changing
RTCP mode, resulting in recreating the stream at most once instead of up
to three times.

BUG=webrtc:5296
R=deadbeef@webrtc.org, pthatcher@webrtc.org
==========

to

==========
Consolidate setters into SetRecvParameters.

Merges SetRecvCodec/SetRecvExtensions and an extra call for changing
RTCP mode, resulting in recreating the stream at most once instead of up
to three times.

BUG=webrtc:5296
R=deadbeef@webrtc.org, pthatcher@webrtc.org
==========

[commit-bot: I haz the power, 2016-01-28 23:58:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 23:58:57]

Description was changed from

==========
Consolidate setters into SetRecvParameters.

Merges SetRecvCodec/SetRecvExtensions and an extra call for changing
RTCP mode, resulting in recreating the stream at most once instead of up
to three times.

BUG=webrtc:5296
R=deadbeef@webrtc.org, pthatcher@webrtc.org
==========

to

==========
Consolidate setters into SetRecvParameters.

Merges SetRecvCodec/SetRecvExtensions and an extra call for changing
RTCP mode, resulting in recreating the stream at most once instead of up
to three times.

BUG=webrtc:5296
R=deadbeef@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/378dc770a6e3c80105ae9b9729855439c8732d80
Cr-Commit-Position: refs/heads/master@{#11422}
==========

[commit-bot: I haz the power, 2016-01-28 23:58:58]

Patchset 2 (id:??) landed as
https://crrev.com/378dc770a6e3c80105ae9b9729855439c8732d80
Cr-Commit-Position: refs/heads/master@{#11422}