Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1640993002: Update API for Objective-C RTCPeerConnection. (Closed)

Created:
4 years, 10 months ago by hjon_webrtc
Modified:
4 years, 10 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update API for Objective-C RTCPeerConnection. BUG= Committed: https://crrev.com/f396f6085f9e4f16f37471a7828e3e31308c0d52 Cr-Commit-Position: refs/heads/master@{#11590}

Patch Set 1 #

Patch Set 2 : Fix some style issues #

Total comments: 57

Patch Set 3 : Changes based on feedback #

Total comments: 42

Patch Set 4 : Changes based on feedback #

Patch Set 5 : Update against master #

Total comments: 66

Patch Set 6 : Changes based on feedback #

Patch Set 7 : Update against master #

Total comments: 8

Patch Set 8 : Changes based on feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+859 lines, -4 lines) Patch
M webrtc/api/BUILD.gn View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/api/api.gyp View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCIceCandidate.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/objc/RTCIceCandidate+Private.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A webrtc/api/objc/RTCPeerConnection.h View 1 2 3 4 5 6 7 1 chunk +181 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCPeerConnection.mm View 1 2 3 4 5 6 7 1 chunk +479 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCPeerConnection+DataChannel.mm View 1 2 3 4 5 6 7 1 chunk +31 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCPeerConnection+Private.h View 1 2 3 4 5 6 7 1 chunk +90 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCPeerConnection+Stats.mm View 1 2 3 4 5 6 7 1 chunk +64 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCSessionDescription.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/objc/RTCSessionDescription+Private.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (5 generated)
hjon_webrtc
@tkchin Could you give this a quick look as-is? Definitely need to fix some line ...
4 years, 10 months ago (2016-01-28 00:11:46 UTC) #2
hjon_webrtc
At least style-wise, I think this is a better place than the first patch set.
4 years, 10 months ago (2016-01-29 00:05:43 UTC) #3
tkchin_webrtc
https://codereview.webrtc.org/1640993002/diff/20001/webrtc/api/BUILD.gn File webrtc/api/BUILD.gn (right): https://codereview.webrtc.org/1640993002/diff/20001/webrtc/api/BUILD.gn#newcode59 webrtc/api/BUILD.gn:59: #"objc/RTCPeerConnectionDelegate.h", Remove Delegate/Observer. Delegate should be declared in RTCPeerConnection.h ...
4 years, 10 months ago (2016-02-01 10:00:02 UTC) #4
hjon_webrtc
https://codereview.webrtc.org/1640993002/diff/20001/webrtc/api/BUILD.gn File webrtc/api/BUILD.gn (right): https://codereview.webrtc.org/1640993002/diff/20001/webrtc/api/BUILD.gn#newcode59 webrtc/api/BUILD.gn:59: #"objc/RTCPeerConnectionDelegate.h", On 2016/02/01 10:00:01, tkchin_webrtc wrote: > Remove Delegate/Observer. ...
4 years, 10 months ago (2016-02-04 00:58:38 UTC) #5
tkchin_webrtc
https://codereview.webrtc.org/1640993002/diff/20001/webrtc/api/BUILD.gn File webrtc/api/BUILD.gn (right): https://codereview.webrtc.org/1640993002/diff/20001/webrtc/api/BUILD.gn#newcode59 webrtc/api/BUILD.gn:59: #"objc/RTCPeerConnectionDelegate.h", On 2016/02/04 00:58:37, hjon_webrtc wrote: > On 2016/02/01 ...
4 years, 10 months ago (2016-02-05 16:15:16 UTC) #6
hjon_webrtc
https://codereview.webrtc.org/1640993002/diff/40001/webrtc/api/objc/RTCPeerConnection+Private.h File webrtc/api/objc/RTCPeerConnection+Private.h (right): https://codereview.webrtc.org/1640993002/diff/40001/webrtc/api/objc/RTCPeerConnection+Private.h#newcode29 webrtc/api/objc/RTCPeerConnection+Private.h:29: /** Triggered when the SignalingState changed. */ On 2016/02/05 ...
4 years, 10 months ago (2016-02-09 00:59:54 UTC) #7
tkchin_webrtc
https://codereview.webrtc.org/1640993002/diff/40001/webrtc/api/objc/RTCPeerConnection.h File webrtc/api/objc/RTCPeerConnection.h (right): https://codereview.webrtc.org/1640993002/diff/40001/webrtc/api/objc/RTCPeerConnection.h#newcode26 webrtc/api/objc/RTCPeerConnection.h:26: extern NSString * _Nonnull const kRTCPeerConnectionErrorDomain; On 2016/02/09 00:59:54, ...
4 years, 10 months ago (2016-02-10 18:54:41 UTC) #8
hjon_webrtc
https://codereview.webrtc.org/1640993002/diff/40001/webrtc/api/objc/RTCPeerConnection.h File webrtc/api/objc/RTCPeerConnection.h (right): https://codereview.webrtc.org/1640993002/diff/40001/webrtc/api/objc/RTCPeerConnection.h#newcode26 webrtc/api/objc/RTCPeerConnection.h:26: extern NSString * _Nonnull const kRTCPeerConnectionErrorDomain; On 2016/02/10 18:54:40, ...
4 years, 10 months ago (2016-02-11 00:25:09 UTC) #9
hjon_webrtc
https://codereview.webrtc.org/1640993002/diff/120001/webrtc/api/objc/RTCPeerConnection.h File webrtc/api/objc/RTCPeerConnection.h (right): https://codereview.webrtc.org/1640993002/diff/120001/webrtc/api/objc/RTCPeerConnection.h#newcode149 webrtc/api/objc/RTCPeerConnection.h:149: completionHandler:(void (^)(RTCSessionDescription *sessionDescription, Looks like this is actually 81 ...
4 years, 10 months ago (2016-02-11 17:29:48 UTC) #10
tkchin_webrtc
lgrm https://codereview.webrtc.org/1640993002/diff/120001/webrtc/api/objc/RTCPeerConnection+DataChannel.mm File webrtc/api/objc/RTCPeerConnection+DataChannel.mm (right): https://codereview.webrtc.org/1640993002/diff/120001/webrtc/api/objc/RTCPeerConnection+DataChannel.mm#newcode11 webrtc/api/objc/RTCPeerConnection+DataChannel.mm:11: #import "RTCPeerConnection+Private.h" webrtc/api https://codereview.webrtc.org/1640993002/diff/120001/webrtc/api/objc/RTCPeerConnection+Private.h File webrtc/api/objc/RTCPeerConnection+Private.h (right): https://codereview.webrtc.org/1640993002/diff/120001/webrtc/api/objc/RTCPeerConnection+Private.h#newcode11 ...
4 years, 10 months ago (2016-02-11 18:19:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640993002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640993002/140001
4 years, 10 months ago (2016-02-11 20:43:55 UTC) #13
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2016-02-11 20:43:56 UTC) #15
tkchin_webrtc
On 2016/02/11 20:43:56, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 10 months ago (2016-02-11 22:04:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640993002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640993002/140001
4 years, 10 months ago (2016-02-11 22:15:46 UTC) #18
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 10 months ago (2016-02-12 00:19:10 UTC) #19
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 00:19:19 UTC) #21
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/f396f6085f9e4f16f37471a7828e3e31308c0d52
Cr-Commit-Position: refs/heads/master@{#11590}

Powered by Google App Engine
This is Rietveld 408576698