Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1640173004: Revert of Adding "first packet received" notification to PeerConnectionObserver. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/peerconnection_unittest.cc ('k') | talk/app/webrtc/webrtcsession.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 // New Ice candidate have been found. 477 // New Ice candidate have been found.
478 virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0; 478 virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0;
479 479
480 // TODO(bemasc): Remove this once callers transition to OnIceGatheringChange. 480 // TODO(bemasc): Remove this once callers transition to OnIceGatheringChange.
481 // All Ice candidates have been found. 481 // All Ice candidates have been found.
482 virtual void OnIceComplete() {} 482 virtual void OnIceComplete() {}
483 483
484 // Called when the ICE connection receiving status changes. 484 // Called when the ICE connection receiving status changes.
485 virtual void OnIceConnectionReceivingChange(bool receiving) {} 485 virtual void OnIceConnectionReceivingChange(bool receiving) {}
486 486
487 // Called when the first RTP packet is received.
488 virtual void OnFirstMediaPacketReceived() {}
489
490 protected: 487 protected:
491 // Dtor protected as objects shouldn't be deleted via this interface. 488 // Dtor protected as objects shouldn't be deleted via this interface.
492 ~PeerConnectionObserver() {} 489 ~PeerConnectionObserver() {}
493 }; 490 };
494 491
495 // PeerConnectionFactoryInterface is the factory interface use for creating 492 // PeerConnectionFactoryInterface is the factory interface use for creating
496 // PeerConnection, MediaStream and media tracks. 493 // PeerConnection, MediaStream and media tracks.
497 // PeerConnectionFactoryInterface will create required libjingle threads, 494 // PeerConnectionFactoryInterface will create required libjingle threads,
498 // socket and network manager factory classes for networking. 495 // socket and network manager factory classes for networking.
499 // If an application decides to provide its own threads and network 496 // If an application decides to provide its own threads and network
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
605 CreatePeerConnectionFactory( 602 CreatePeerConnectionFactory(
606 rtc::Thread* worker_thread, 603 rtc::Thread* worker_thread,
607 rtc::Thread* signaling_thread, 604 rtc::Thread* signaling_thread,
608 AudioDeviceModule* default_adm, 605 AudioDeviceModule* default_adm,
609 cricket::WebRtcVideoEncoderFactory* encoder_factory, 606 cricket::WebRtcVideoEncoderFactory* encoder_factory,
610 cricket::WebRtcVideoDecoderFactory* decoder_factory); 607 cricket::WebRtcVideoDecoderFactory* decoder_factory);
611 608
612 } // namespace webrtc 609 } // namespace webrtc
613 610
614 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_ 611 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/peerconnection_unittest.cc ('k') | talk/app/webrtc/webrtcsession.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698