Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1640173004: Revert of Adding "first packet received" notification to PeerConnectionObserver. (Closed)

Created:
4 years, 11 months ago by Taylor Brandstetter
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding "first packet received" notification to PeerConnectionObserver. (patchset #4 id:60001 of https://codereview.webrtc.org/1581693006/ ) Reason for revert: Seems that the end-to-end unit tests are now flaky: https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug/builds/6283 Will reland after fixing the test flakiness. Original issue's description: > Adding "first packet received" notification to PeerConnectionObserver. > > R=glaznev@webrtc.org, pthatcher@webrtc.org, tkchin@webrtc.org > > Committed: https://crrev.com/42265a8cc3b3f3db4aa2c29005aed2fb4393adef > Cr-Commit-Position: refs/heads/master@{#11401} TBR=pthatcher@webrtc.org,tkchin@webrtc.org,glaznev@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7b3c72ffa9f4122192e9bb0d67b7794b28182511 Cr-Commit-Position: refs/heads/master@{#11402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -79 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnection.java View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/objc/RTCPeerConnectionObserver.h View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/objc/RTCPeerConnectionObserver.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M talk/app/webrtc/objc/public/RTCPeerConnectionDelegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m View 1 chunk +0 lines, -4 lines 0 comments Download
M talk/app/webrtc/peerconnection.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnection.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 4 chunks +0 lines, -11 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/webrtcsession.h View 3 chunks +0 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/examples/objc/AppRTCDemo/ARDAppClient.m View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Taylor Brandstetter
Created Revert of Adding "first packet received" notification to PeerConnectionObserver.
4 years, 11 months ago (2016-01-27 21:03:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640173004/1
4 years, 11 months ago (2016-01-27 21:03:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 21:03:46 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 21:03:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b3c72ffa9f4122192e9bb0d67b7794b28182511
Cr-Commit-Position: refs/heads/master@{#11402}

Powered by Google App Engine
This is Rietveld 408576698