Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1639883002:
Remove incorrect cast to AsyncSocketAdapter. (Closed)
|
Created:
4 years, 11 months ago by pbos-webrtc Modified:
4 years, 11 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove incorrect cast to AsyncSocketAdapter.
socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but
doesn't have to be an AsyncSocketAdapter. In tests this is
rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the
BIO_new_socket type signature.
This fixes the remaining UBSan vptr bot errors.
BUG=webrtc:5124, webrtc:5226
R=tommi@webrtc.org, torbjorng@webrtc.org
Committed: https://crrev.com/0b518bf6fcf87b652546a232a6ea8e53c6c4d316
Cr-Commit-Position: refs/heads/master@{#11391}
Patch Set 1 #Patch Set 2 : didn't even need a cast, woot #Messages
Total messages: 22 (11 generated)
PTAL
pbos@webrtc.org changed reviewers: + tommi@webrtc.org
+R tommi@ for ownership.
The CQ bit was checked by pbos@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639883002/1
Description was changed from ========== Replace incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be a AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is a rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This should fix the remaining UBSan vptr bot errors. BUG=webrtc:5124 R=torbjorng@webrtc.org ========== to ========== Replace incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This should fix the remaining UBSan vptr bot errors. BUG=webrtc:5124 R=torbjorng@webrtc.org ==========
didn't even need a cast, woot
Description was changed from ========== Replace incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This should fix the remaining UBSan vptr bot errors. BUG=webrtc:5124 R=torbjorng@webrtc.org ========== to ========== Remove incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This should fix the remaining UBSan vptr bot errors. BUG=webrtc:5124 R=torbjorng@webrtc.org ==========
Description was changed from ========== Remove incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This should fix the remaining UBSan vptr bot errors. BUG=webrtc:5124 R=torbjorng@webrtc.org ========== to ========== Remove incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This should fix the remaining UBSan vptr bot errors. BUG=webrtc:5124 R=tommi@webrtc.org, torbjorng@webrtc.org ==========
Example failure here: https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan%20vptr/...
Description was changed from ========== Remove incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This should fix the remaining UBSan vptr bot errors. BUG=webrtc:5124 R=tommi@webrtc.org, torbjorng@webrtc.org ========== to ========== Remove incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This should fix the remaining UBSan vptr bot errors. BUG=webrtc:5124, webrtc:5226 R=tommi@webrtc.org, torbjorng@webrtc.org ==========
Description was changed from ========== Remove incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This should fix the remaining UBSan vptr bot errors. BUG=webrtc:5124, webrtc:5226 R=tommi@webrtc.org, torbjorng@webrtc.org ========== to ========== Remove incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This fixes the remaining UBSan vptr bot errors. BUG=webrtc:5124, webrtc:5226 R=tommi@webrtc.org, torbjorng@webrtc.org ==========
The CQ bit was checked by tommi@webrtc.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639883002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
lgtm
Description was changed from ========== Remove incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This fixes the remaining UBSan vptr bot errors. BUG=webrtc:5124, webrtc:5226 R=tommi@webrtc.org, torbjorng@webrtc.org ========== to ========== Remove incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This fixes the remaining UBSan vptr bot errors. BUG=webrtc:5124, webrtc:5226 R=tommi@webrtc.org, torbjorng@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/0b518bf6fcf87b652546a232a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 0b518bf6fcf87b652546a232a6ea8e53c6c4d316 (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Remove incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This fixes the remaining UBSan vptr bot errors. BUG=webrtc:5124, webrtc:5226 R=tommi@webrtc.org, torbjorng@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/0b518bf6fcf87b652546a232a... ========== to ========== Remove incorrect cast to AsyncSocketAdapter. socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but doesn't have to be an AsyncSocketAdapter. In tests this is rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the BIO_new_socket type signature. This fixes the remaining UBSan vptr bot errors. BUG=webrtc:5124, webrtc:5226 R=tommi@webrtc.org, torbjorng@webrtc.org Committed: https://crrev.com/0b518bf6fcf87b652546a232a6ea8e53c6c4d316 Cr-Commit-Position: refs/heads/master@{#11391} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0b518bf6fcf87b652546a232a6ea8e53c6c4d316 Cr-Commit-Position: refs/heads/master@{#11391} |
