Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1639283002: Clang format changes (Closed)

Created:
4 years, 11 months ago by peah-webrtc
Modified:
4 years, 10 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Format changes achieved by running clang-format -i -style=Chromium BUG= Committed: https://crrev.com/ff63ed2888fcc6747353a777d885b2001369bab6 Cr-Commit-Position: refs/heads/master@{#11427}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reverted the reformatting of the MIPS assembly code #

Patch Set 3 : Merged with latest code from master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -379 lines) Patch
M webrtc/modules/audio_processing/aec/aec_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.h View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.c View 1 2 36 chunks +103 lines, -145 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_mips.c View 1 7 chunks +15 lines, -15 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_neon.c View 15 chunks +53 lines, -56 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_sse2.c View 15 chunks +73 lines, -80 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_resampler.h View 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_resampler.c View 5 chunks +5 lines, -10 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation.h View 1 chunk +3 lines, -10 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation.c View 10 chunks +18 lines, -45 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
peah-webrtc
4 years, 11 months ago (2016-01-27 13:46:10 UTC) #3
kwiberg-webrtc
lgtm (but see comment) None of these files had completely impossible indentation. I thought you ...
4 years, 11 months ago (2016-01-27 14:08:21 UTC) #4
peah-webrtc
On 2016/01/27 14:08:21, kwiberg-webrtc wrote: > lgtm (but see comment) > > None of these ...
4 years, 11 months ago (2016-01-28 10:04:42 UTC) #5
peah-webrtc
4 years, 11 months ago (2016-01-28 10:04:47 UTC) #6
kwiberg-webrtc
On 2016/01/28 10:04:42, peah-webrtc wrote: > Totally agree. Ok if I immediately revert the referred ...
4 years, 11 months ago (2016-01-28 10:43:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639283002/20001
4 years, 11 months ago (2016-01-28 11:43:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_arm64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/7137) ios_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 11 months ago (2016-01-28 11:45:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639283002/40001
4 years, 10 months ago (2016-01-29 14:41:09 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-01-29 15:46:16 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 15:46:24 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ff63ed2888fcc6747353a777d885b2001369bab6
Cr-Commit-Position: refs/heads/master@{#11427}

Powered by Google App Engine
This is Rietveld 408576698