webrtc/modules/video_coding/BUILD.gn - Issue 1639273002: H264: Thread-safe InitializeFFmpeg. Flag to control if InitializeFFmpeg should be called.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/BUILD.gn

Issue 1639273002: H264: Thread-safe InitializeFFmpeg. Flag to control if InitializeFFmpeg should be called. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/build/webrtc.gni ('k') | webrtc/modules/video_coding/codecs/h264/h264.gypi » ('j') | webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/BUILD.gn

diff --git a/webrtc/modules/video_coding/BUILD.gn b/webrtc/modules/video_coding/BUILD.gn

index 115ed3588b90e30a5130517583c85e6e3f3eb4dc..9117a6744580f31fec4f6b9482b8227537f4875d 100644

--- a/webrtc/modules/video_coding/BUILD.gn

+++ b/webrtc/modules/video_coding/BUILD.gn

@@ -140,6 +140,9 @@ source_set("webrtc_h264") {

if (rtc_use_h264) {

defines += [ "WEBRTC_THIRD_PARTY_H264" ]

+ if (!rtc_skip_ffmpeg_init) {

stefan-webrtc 2016/01/27 14:00:38 Doesn't it make more sense to call this rtc_init_f

hbos 2016/01/28 10:31:09 Yeah you're right, heh, I made it that way so I co

+ defines += [ "WEBRTC_INITIALIZE_FFMPEG" ]

+ }

sources += [

"codecs/h264/h264_decoder_impl.cc",

"codecs/h264/h264_decoder_impl.h",