webrtc/modules/rtp_rtcp/source/rtcp_sender.h - Issue 1639253007: Validates sending RTCP before RTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.h

Issue 1639253007: Validates sending RTCP before RTP. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: fix tests and receive-only case Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_sender.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender.h b/webrtc/modules/rtp_rtcp/source/rtcp_sender.h

index 4ee751f37c48ba6d8404af5d5ebd257014c6a65b..3a5030c529d3e6af79525c8180e1892404ece9d3 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender.h

@@ -156,8 +156,7 @@ class RTCPSender {

class RtcpContext;

// Determine which RTCP messages should be sent and setup flags.

- void PrepareReport(const std::set<RTCPPacketType>& packetTypes,

- const FeedbackState& feedback_state)

+ void PrepareReport(const FeedbackState& feedback_state)

EXCLUSIVE_LOCKS_REQUIRED(critical_section_rtcp_sender_);

bool AddReportBlock(const FeedbackState& feedback_state,