Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1638553003: Reland "Removing webrtc::AudioFrame::energy_." (Closed)

Created:
4 years, 11 months ago by minyue-webrtc
Modified:
4 years, 10 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Removing webrtc::AudioFrame::energy_." Some WebRTC client had a problem with the change "Removing webrtc::AudioFrame::energy_". Now it is solved. This reverts commit 2bdcfadc8abd418a30dd5cdf54ba45a429d3d9bf. BUG=webrtc:3315 Committed: https://crrev.com/e37a2d180238bcf8c74b6dede72d0b9d6c08cb9d Cr-Commit-Position: refs/heads/master@{#11448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -39 lines) Patch
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc View 2 chunks +4 lines, -17 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_frame_manipulator.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_frame_manipulator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/include/module_common_types.h View 8 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
minyue-webrtc
Hi Tommi, There was an obstacle for this CL to land, which has been removed.
4 years, 11 months ago (2016-01-26 15:25:42 UTC) #3
minyue-webrtc
On 2016/01/26 15:25:42, minyue-webrtc wrote: > Hi Tommi, > > There was an obstacle for ...
4 years, 11 months ago (2016-01-28 09:38:29 UTC) #5
minyue-webrtc
On 2016/01/28 09:38:29, minyue-webrtc wrote: > On 2016/01/26 15:25:42, minyue-webrtc wrote: > > Hi Tommi, ...
4 years, 10 months ago (2016-02-01 14:55:06 UTC) #6
tommi
lgtm
4 years, 10 months ago (2016-02-01 16:21:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638553003/1
4 years, 10 months ago (2016-02-01 17:01:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 18:02:43 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 18:02:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e37a2d180238bcf8c74b6dede72d0b9d6c08cb9d
Cr-Commit-Position: refs/heads/master@{#11448}

Powered by Google App Engine
This is Rietveld 408576698