Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1635823004: Fix BasicNetworkManager not to spam logs when internet is unreacheable. (Closed)

Created:
4 years, 11 months ago by Sergey Ulanov
Modified:
4 years, 11 months ago
Reviewers:
pthatcher2, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix BasicNetworkManager not to spam logs when internet is unreacheable. BasicNetworkManager attemps to connect an UDP socket and logs an error when connect() fails, e.g. when internet is not connected. These errors are not very useful in the logs, but apper there every time it attemps to refresh network list. Replaced the log statement with LOG(LS_INFO). R=pthatcher@webrtc.org Committed: https://crrev.com/fab0a2886d7ad3d664d1ef4d1c92190514c57764 Cr-Commit-Position: refs/heads/master@{#11389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/base/network.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Sergey Ulanov
4 years, 11 months ago (2016-01-26 18:33:32 UTC) #2
pthatcher1
lgtm
4 years, 11 months ago (2016-01-27 01:42:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635823004/1
4 years, 11 months ago (2016-01-27 01:43:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/588)
4 years, 11 months ago (2016-01-27 02:05:15 UTC) #8
Sergey Ulanov
Committed patchset #1 (id:1) manually as fab0a2886d7ad3d664d1ef4d1c92190514c57764 (presubmit successful).
4 years, 11 months ago (2016-01-27 06:13:08 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 06:13:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fab0a2886d7ad3d664d1ef4d1c92190514c57764
Cr-Commit-Position: refs/heads/master@{#11389}

Powered by Google App Engine
This is Rietveld 408576698