Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1631683002: [rtp_rtcp] Dlrr::SubBlock struct renamed to ReceiveTimeInfo (Closed)

Created:
4 years, 11 months ago by danilchap
Modified:
4 years, 11 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] Dlrr::SubBlock struct renamed to ReceiveTimeInfo This structure is used outside Dlrr creating/parsing. but RTCPReceiveTimeInfo structure doesn't follow naming style. rtcp::ReceiveTimeInfo added to replace both Dlrr::SubBlock (when creating/parsing packets) and RTCPReceiveTimeInfo (for other uses). this CL is a split of https://codereview.webrtc.org/1557593002/ BUG=webrtc:5260 R=asapersson@webrtc.org, åsapersson Committed: https://crrev.com/d0c7bba4f403a425adf3ed90847dcc3cdeaeab1f Cr-Commit-Position: refs/heads/master@{#11380}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h View 2 chunks +12 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc View 1 3 chunks +12 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
danilchap
4 years, 11 months ago (2016-01-25 16:08:17 UTC) #1
åsapersson
https://codereview.webrtc.org/1631683002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc (right): https://codereview.webrtc.org/1631683002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc#newcode95 webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc:95: uint32_t delay_last_rr) { Call function above here? ReceiveTimeInfo block; ...
4 years, 11 months ago (2016-01-26 12:37:00 UTC) #2
danilchap
https://codereview.webrtc.org/1631683002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc (right): https://codereview.webrtc.org/1631683002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc#newcode95 webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc:95: uint32_t delay_last_rr) { On 2016/01/26 12:37:00, åsapersson wrote: > ...
4 years, 11 months ago (2016-01-26 12:46:37 UTC) #3
åsapersson
lgtm
4 years, 11 months ago (2016-01-26 12:47:55 UTC) #4
danilchap
Committed patchset #2 (id:20001) manually as d0c7bba4f403a425adf3ed90847dcc3cdeaeab1f (presubmit successful).
4 years, 11 months ago (2016-01-26 13:13:03 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 13:13:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0c7bba4f403a425adf3ed90847dcc3cdeaeab1f
Cr-Commit-Position: refs/heads/master@{#11380}

Powered by Google App Engine
This is Rietveld 408576698