Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: webrtc/modules/pacing/packet_router.h

Issue 1628683002: Use separate rtp module lists for send and receive in PacketRouter. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/pacing/packet_router.cc » ('j') | webrtc/modules/pacing/packet_router.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/pacing/packet_router.h
diff --git a/webrtc/modules/pacing/packet_router.h b/webrtc/modules/pacing/packet_router.h
index edef1aa9b3f89618b6c33625487225aebac26c88..68326aa857943882be2a371fb4a2c796bb66fe1c 100644
--- a/webrtc/modules/pacing/packet_router.h
+++ b/webrtc/modules/pacing/packet_router.h
@@ -36,8 +36,8 @@ class PacketRouter : public PacedSender::Callback,
PacketRouter();
virtual ~PacketRouter();
- void AddRtpModule(RtpRtcp* rtp_module);
- void RemoveRtpModule(RtpRtcp* rtp_module);
+ void AddRtpModule(RtpRtcp* rtp_module, bool sender);
+ void RemoveRtpModule(RtpRtcp* rtp_module, bool sender);
// Implements PacedSender::Callback.
bool TimeToSendPacket(uint32_t ssrc,
@@ -54,9 +54,11 @@ class PacketRouter : public PacedSender::Callback,
virtual bool SendFeedback(rtcp::TransportFeedback* packet);
private:
- rtc::CriticalSection modules_lock_;
+ rtc::CriticalSection send_modules_crit_;
+ rtc::CriticalSection recv_modules_crit_;
// Map from ssrc to sending rtp module.
the sun 2016/01/26 09:17:02 Bad comment?
stefan-webrtc 2016/01/26 10:50:38 Done.
- std::list<RtpRtcp*> rtp_modules_ GUARDED_BY(modules_lock_);
+ std::list<RtpRtcp*> send_rtp_modules_ GUARDED_BY(send_modules_crit_);
+ std::list<RtpRtcp*> recv_rtp_modules_ GUARDED_BY(recv_modules_crit_);
volatile int transport_seq_;
« no previous file with comments | « no previous file | webrtc/modules/pacing/packet_router.cc » ('j') | webrtc/modules/pacing/packet_router.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698