Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: webrtc/modules/pacing/packet_router_unittest.cc

Issue 1628683002: Use separate rtp module lists for send and receive in PacketRouter. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/pacing/packet_router_unittest.cc
diff --git a/webrtc/modules/pacing/packet_router_unittest.cc b/webrtc/modules/pacing/packet_router_unittest.cc
index 31acf44b9b8c91418509e97675649a1aac025aeb..61237554c0ecf90e235bd547b8630c93ee339895 100644
--- a/webrtc/modules/pacing/packet_router_unittest.cc
+++ b/webrtc/modules/pacing/packet_router_unittest.cc
@@ -16,6 +16,7 @@
#include "webrtc/modules/pacing/packet_router.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp.h"
#include "webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
+#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
#include "webrtc/base/scoped_ptr.h"
using ::testing::_;
@@ -35,8 +36,8 @@ class PacketRouterTest : public ::testing::Test {
TEST_F(PacketRouterTest, TimeToSendPacket) {
MockRtpRtcp rtp_1;
MockRtpRtcp rtp_2;
- packet_router_->AddRtpModule(&rtp_1);
- packet_router_->AddRtpModule(&rtp_2);
+ packet_router_->AddRtpModule(&rtp_1, true);
+ packet_router_->AddRtpModule(&rtp_2, true);
const uint16_t kSsrc1 = 1234;
uint16_t sequence_number = 17;
@@ -109,8 +110,8 @@ TEST_F(PacketRouterTest, TimeToSendPadding) {
EXPECT_CALL(rtp_1, SSRC()).WillRepeatedly(Return(kSsrc1));
MockRtpRtcp rtp_2;
EXPECT_CALL(rtp_2, SSRC()).WillRepeatedly(Return(kSsrc2));
- packet_router_->AddRtpModule(&rtp_1);
- packet_router_->AddRtpModule(&rtp_2);
+ packet_router_->AddRtpModule(&rtp_1, true);
+ packet_router_->AddRtpModule(&rtp_2, true);
// Default configuration, sending padding on all modules sending media,
// ordered by SSRC.
@@ -169,4 +170,19 @@ TEST_F(PacketRouterTest, AllocateSequenceNumbers) {
EXPECT_EQ(static_cast<uint16_t>(expected_unwrapped_seq & 0xFFFF), seq);
}
}
+
+TEST_F(PacketRouterTest, SendFeedback) {
+ MockRtpRtcp rtp_1;
+ MockRtpRtcp rtp_2;
+ packet_router_->AddRtpModule(&rtp_1, false);
+ packet_router_->AddRtpModule(&rtp_2, true);
+
+ rtcp::TransportFeedback feedback;
+ EXPECT_CALL(rtp_1, SendFeedbackPacket(_)).Times(1);
+ packet_router_->SendFeedback(&feedback);
+ packet_router_->RemoveRtpModule(&rtp_1);
+ EXPECT_CALL(rtp_2, SendFeedbackPacket(_)).Times(1);
+ packet_router_->SendFeedback(&feedback);
+ packet_router_->RemoveRtpModule(&rtp_2);
+}
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698