Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1621453005: Fix compilation if HAVE_WEBRTC_VIDEO is not defined. (Closed)

Created:
4 years, 11 months ago by joachim
Modified:
4 years, 11 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix compilation if HAVE_WEBRTC_VIDEO is not defined. This CL fixes compiler / linker errors that occur if HAVE_WEBRTC_VIDEO is not defined and introduces a new class NullWebRtcVideoEngine to use in that case. BUG= TEST=remove define HAVE_WEBRTC_VIDEO from talk/build/common.gypi, run gclient runhooks and compile

Patch Set 1 #

Patch Set 2 : Fixed wrong filename in gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -42 lines) Patch
M talk/libjingle.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M talk/libjingle_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + talk/media/webrtc/nullwebrtcvideoengine.h View 2 chunks +39 lines, -28 lines 0 comments Download
A + talk/media/webrtc/nullwebrtcvideoengine_unittest.cc View 1 chunk +22 lines, -13 lines 0 comments Download
M talk/media/webrtc/webrtcmediaengine.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M talk/media/webrtc/webrtcvideocapturer_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M talk/media/webrtc/webrtcvideocapturerfactory.cc View 1 chunk +5 lines, -1 line 0 comments Download
M talk/media/webrtc/webrtcvideoengine2_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
joachim
Ptal
4 years, 11 months ago (2016-01-22 20:45:51 UTC) #2
tommi
lgtm
4 years, 11 months ago (2016-01-24 13:51:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621453005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621453005/1
4 years, 11 months ago (2016-01-24 13:51:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/8588)
4 years, 11 months ago (2016-01-24 13:52:54 UTC) #7
tommi
On 2016/01/24 13:52:54, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 11 months ago (2016-01-24 14:01:59 UTC) #8
joachim
Sorry, the "nullwebrtcvideoengine.h" started as "nullwebrtcmediaengine.h" while I developed this CL and I forgot updating ...
4 years, 11 months ago (2016-01-24 14:06:19 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621453005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621453005/20001
4 years, 11 months ago (2016-01-26 00:00:13 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 01:36:26 UTC) #13
joachim
On 2016/01/26 01:36:26, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 11 months ago (2016-01-26 08:42:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621453005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621453005/20001
4 years, 11 months ago (2016-01-26 21:03:43 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4cb3e3997b547cd28a92a4f323f14575019756fa Cr-Commit-Position: refs/heads/master@{#11387}
4 years, 11 months ago (2016-01-26 21:08:04 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 21:08:12 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698