Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1620013002: Sync build_ios_libs.sh script with http://webrtc.org/native-code/ios/ (Closed)

Created:
4 years, 11 months ago by hjon_webrtc
Modified:
4 years, 10 months ago
Reviewers:
jiayl2, tkchin_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Sync build_ios_libs.sh script with http://webrtc.org/native-code/ios/ BUG= Committed: https://crrev.com/3ea1852f9e81424946be285a7b2ffe69e8e6f5d5 Cr-Commit-Position: refs/heads/master@{#11388}

Patch Set 1 #

Patch Set 2 : Use Xcode's clang #

Total comments: 2

Patch Set 3 : Changes from feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M talk/build/build_ios_libs.sh View 1 2 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
hjon_webrtc
4 years, 11 months ago (2016-01-21 22:48:36 UTC) #2
tkchin_webrtc
lgtm +jiayl for rubber stamp https://codereview.webrtc.org/1620013002/diff/20001/talk/build/build_ios_libs.sh File talk/build/build_ios_libs.sh (right): https://codereview.webrtc.org/1620013002/diff/20001/talk/build/build_ios_libs.sh#newcode69 talk/build/build_ios_libs.sh:69: export GYP_DEFINES="${GYP_DEFINES} target_arch=${TARGET_ARCH} clang_xcode=1" ...
4 years, 11 months ago (2016-01-21 23:15:29 UTC) #4
hjon_webrtc
https://codereview.webrtc.org/1620013002/diff/20001/talk/build/build_ios_libs.sh File talk/build/build_ios_libs.sh (right): https://codereview.webrtc.org/1620013002/diff/20001/talk/build/build_ios_libs.sh#newcode69 talk/build/build_ios_libs.sh:69: export GYP_DEFINES="${GYP_DEFINES} target_arch=${TARGET_ARCH} clang_xcode=1" On 2016/01/21 23:15:29, tkchin_webrtc wrote: ...
4 years, 11 months ago (2016-01-21 23:19:27 UTC) #5
tkchin_webrtc
ping @jiayl
4 years, 10 months ago (2016-01-26 20:07:15 UTC) #6
jiayl2
lgtm
4 years, 10 months ago (2016-01-26 20:07:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620013002/40001
4 years, 10 months ago (2016-01-26 20:14:04 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-01-26 21:43:25 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 21:43:30 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3ea1852f9e81424946be285a7b2ffe69e8e6f5d5
Cr-Commit-Position: refs/heads/master@{#11388}

Powered by Google App Engine
This is Rietveld 408576698