Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1620003003: Enable cpplint for webrtc/modules/bitrate_controller and fix all uncovered cpplint errors. (Closed)

Created:
4 years, 11 months ago by joachim
Modified:
4 years, 11 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable cpplint for webrtc/modules/bitrate_controller and fix all uncovered cpplint errors. This CL enableds cpplint for webrtc/modules/bitrate_controller. BUG=webrtc:5311 NOTRY=true TESTED=Fixed issues reported by: find webrtc/modules/bitrate_controller -type f -name *.cc -o -name *.h | xargs cpplint.py followed by 'git cl presubmit'. Committed: https://crrev.com/f91e6d04381cd420a831a42ccc8c9cb068eba8e5 Cr-Commit-Position: refs/heads/master@{#11363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
joachim
Ptal
4 years, 11 months ago (2016-01-22 21:15:13 UTC) #2
mflodman
LGTM!
4 years, 11 months ago (2016-01-25 06:52:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620003003/1
4 years, 11 months ago (2016-01-25 07:03:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 07:05:25 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 07:05:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f91e6d04381cd420a831a42ccc8c9cb068eba8e5
Cr-Commit-Position: refs/heads/master@{#11363}

Powered by Google App Engine
This is Rietveld 408576698