Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1619213003: Include relay protocol type when computing the turn candidate foundation. (Closed)

Created:
4 years, 11 months ago by honghaiz3
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Include relay protocol type when computing the turn candidate foundation. BUG=576353 R=deadbeef@webrtc.org, pthatcher@google.com, pthatcher@webrtc.org Committed: https://crrev.com/80f1db971db3d0d7ca42e77175fab820121e1bea Cr-Commit-Position: refs/heads/master@{#11400}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M webrtc/p2p/base/port.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 3 chunks +20 lines, -8 lines 0 comments Download
M webrtc/p2p/base/testturnserver.h View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
honghaiz3
4 years, 11 months ago (2016-01-23 03:13:21 UTC) #5
pthatcher
lgtm
4 years, 11 months ago (2016-01-27 01:36:37 UTC) #7
Taylor Brandstetter
lgtm
4 years, 11 months ago (2016-01-27 02:05:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619213003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619213003/40001
4 years, 11 months ago (2016-01-27 03:14:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3090)
4 years, 11 months ago (2016-01-27 03:21:17 UTC) #12
honghaiz3
On 2016/01/27 03:21:17, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 11 months ago (2016-01-27 03:29:43 UTC) #13
pthatcher1
lgtm
4 years, 11 months ago (2016-01-27 18:42:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619213003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619213003/40001
4 years, 11 months ago (2016-01-27 18:56:03 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/634)
4 years, 11 months ago (2016-01-27 19:40:58 UTC) #18
honghaiz3
Committed patchset #1 (id:40001) manually as 80f1db971db3d0d7ca42e77175fab820121e1bea (presubmit successful).
4 years, 11 months ago (2016-01-27 19:54:49 UTC) #20
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 19:54:53 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80f1db971db3d0d7ca42e77175fab820121e1bea
Cr-Commit-Position: refs/heads/master@{#11400}

Powered by Google App Engine
This is Rietveld 408576698