Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1619153003: CriticalSection: Use types+methods from base/platform_thread*.*. (Closed)

Created:
4 years, 11 months ago by tommi
Modified:
4 years, 11 months ago
Reviewers:
joachim
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

CriticalSection: Use types+methods from base/platform_thread*.*. Use PlatformThreadRef, CurrentThreadRef and IsThreadRefEqual instead of pthread_t, pthread_self and operator== (or !=). BUG= Committed: https://crrev.com/7406b96abc8a7d460c78cd801c7bdd124fcbcb4b Cr-Commit-Position: refs/heads/master@{#11355}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M webrtc/base/criticalsection.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/base/criticalsection.cc View 1 8 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tommi
4 years, 11 months ago (2016-01-22 09:12:13 UTC) #2
joachim
lgtm with one small change https://codereview.webrtc.org/1619153003/diff/1/webrtc/base/criticalsection.cc File webrtc/base/criticalsection.cc (right): https://codereview.webrtc.org/1619153003/diff/1/webrtc/base/criticalsection.cc#newcode59 webrtc/base/criticalsection.cc:59: pthread_t self = CurrentThreadRef(); ...
4 years, 11 months ago (2016-01-22 09:17:01 UTC) #3
tommi
Fix type
4 years, 11 months ago (2016-01-22 11:36:27 UTC) #4
tommi
https://codereview.webrtc.org/1619153003/diff/1/webrtc/base/criticalsection.cc File webrtc/base/criticalsection.cc (right): https://codereview.webrtc.org/1619153003/diff/1/webrtc/base/criticalsection.cc#newcode59 webrtc/base/criticalsection.cc:59: pthread_t self = CurrentThreadRef(); On 2016/01/22 09:17:01, joachim wrote: ...
4 years, 11 months ago (2016-01-22 11:36:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619153003/20001
4 years, 11 months ago (2016-01-22 11:37:08 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 13:13:36 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 13:13:43 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7406b96abc8a7d460c78cd801c7bdd124fcbcb4b
Cr-Commit-Position: refs/heads/master@{#11355}

Powered by Google App Engine
This is Rietveld 408576698