Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1618853002: VideoProcessorImpl using EncodedImage::GetBufferPaddingBytes. (Closed)

Created:
4 years, 11 months ago by hbos
Modified:
4 years, 11 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoProcessorImpl using EncodedImage::GetBufferPaddingBytes. BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5424 Committed: https://crrev.com/3fe2c6a161827612800a7a4092fef7fb13611594 Cr-Commit-Position: refs/heads/master@{#11353}

Patch Set 1 #

Patch Set 2 : Added an RTC_CHECK #

Patch Set 3 : Setting copied_image._size properly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 2 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
hbos
Please take a look stefan, mflodman. This is a quick follow-up to the GetBufferPaddingBytes CL ...
4 years, 11 months ago (2016-01-21 15:59:57 UTC) #2
stefan-webrtc
On 2016/01/21 15:59:57, hbos wrote: > Please take a look stefan, mflodman. > > This ...
4 years, 11 months ago (2016-01-21 17:21:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618853002/40001
4 years, 11 months ago (2016-01-21 22:35:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 11 months ago (2016-01-22 00:35:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618853002/40001
4 years, 11 months ago (2016-01-22 08:06:08 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-22 08:07:16 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 08:07:20 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3fe2c6a161827612800a7a4092fef7fb13611594
Cr-Commit-Position: refs/heads/master@{#11353}

Powered by Google App Engine
This is Rietveld 408576698