Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: talk/app/webrtc/webrtcsession_unittest.cc

Issue 1617653005: Fixing an uninitialized variable in webrtcsession_unittest. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 1459 matching lines...) Expand 10 before | Expand all | Expand 10 after
1470 rtc::scoped_refptr<FakeMetricsObserver> metrics_observer_; 1470 rtc::scoped_refptr<FakeMetricsObserver> metrics_observer_;
1471 // The following flags affect options created for CreateOffer/CreateAnswer. 1471 // The following flags affect options created for CreateOffer/CreateAnswer.
1472 bool send_stream_1_ = false; 1472 bool send_stream_1_ = false;
1473 bool send_stream_2_ = false; 1473 bool send_stream_2_ = false;
1474 bool send_audio_ = false; 1474 bool send_audio_ = false;
1475 bool send_video_ = false; 1475 bool send_video_ = false;
1476 rtc::scoped_refptr<DataChannel> data_channel_; 1476 rtc::scoped_refptr<DataChannel> data_channel_;
1477 // Last values received from data channel creation signal. 1477 // Last values received from data channel creation signal.
1478 std::string last_data_channel_label_; 1478 std::string last_data_channel_label_;
1479 InternalDataChannelInit last_data_channel_config_; 1479 InternalDataChannelInit last_data_channel_config_;
1480 bool session_destroyed_; 1480 bool session_destroyed_ = false;
1481 }; 1481 };
1482 1482
1483 TEST_P(WebRtcSessionTest, TestInitializeWithDtls) { 1483 TEST_P(WebRtcSessionTest, TestInitializeWithDtls) {
1484 InitWithDtls(GetParam()); 1484 InitWithDtls(GetParam());
1485 // SDES is disabled when DTLS is on. 1485 // SDES is disabled when DTLS is on.
1486 EXPECT_EQ(cricket::SEC_DISABLED, session_->SdesPolicy()); 1486 EXPECT_EQ(cricket::SEC_DISABLED, session_->SdesPolicy());
1487 } 1487 }
1488 1488
1489 TEST_F(WebRtcSessionTest, TestInitializeWithoutDtls) { 1489 TEST_F(WebRtcSessionTest, TestInitializeWithoutDtls) {
1490 Init(); 1490 Init();
(...skipping 2836 matching lines...) Expand 10 before | Expand all | Expand 10 after
4327 } 4327 }
4328 4328
4329 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test 4329 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test
4330 // currently fails because upon disconnection and reconnection OnIceComplete is 4330 // currently fails because upon disconnection and reconnection OnIceComplete is
4331 // called more than once without returning to IceGatheringGathering. 4331 // called more than once without returning to IceGatheringGathering.
4332 4332
4333 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests, 4333 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests,
4334 WebRtcSessionTest, 4334 WebRtcSessionTest,
4335 testing::Values(ALREADY_GENERATED, 4335 testing::Values(ALREADY_GENERATED,
4336 DTLS_IDENTITY_STORE)); 4336 DTLS_IDENTITY_STORE));
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698