Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1616843004: Small cleanup in VP9EncoderImpl::GetEncodedLayerFrame. (Closed)

Created:
4 years, 11 months ago by åsapersson
Modified:
4 years, 11 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Small cleanup in VP9EncoderImpl::GetEncodedLayerFrame. BUG= Committed: https://crrev.com/86956ded422462a67936c0caab303f873bc79323 Cr-Commit-Position: refs/heads/master@{#11373}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : updated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 2 3 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
åsapersson
4 years, 11 months ago (2016-01-25 08:19:36 UTC) #2
stefan-webrtc
lgtm https://codereview.webrtc.org/1616843004/diff/20001/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right): https://codereview.webrtc.org/1616843004/diff/20001/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc#newcode664 webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:664: // fragmentation data for now, until VP9 packetizer ...
4 years, 11 months ago (2016-01-25 13:57:38 UTC) #3
åsapersson
https://codereview.webrtc.org/1616843004/diff/20001/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right): https://codereview.webrtc.org/1616843004/diff/20001/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc#newcode664 webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:664: // fragmentation data for now, until VP9 packetizer is ...
4 years, 11 months ago (2016-01-26 07:55:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616843004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616843004/40001
4 years, 11 months ago (2016-01-26 07:55:47 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-26 09:05:24 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 09:05:37 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/86956ded422462a67936c0caab303f873bc79323
Cr-Commit-Position: refs/heads/master@{#11373}

Powered by Google App Engine
This is Rietveld 408576698