Update API for Objective-C RTCDataChannelConfiguration.

Update API for Objective-C RTCDataChannelConfiguration.

BUG=

Committed: https://crrev.com/da2183c86fcdf4cd525ea4cdc63bd3ba95703291
Cr-Commit-Position: refs/heads/master@{#11405}

[hjon_webrtc, 2016-01-22 21:16:49]

hjon@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2016-01-26 20:12:43]

lgtm

https://codereview.webrtc.org/1616363005/diff/1/webrtc/api/objctests/RTCDataC...
File webrtc/api/objctests/RTCDataChannelConfigurationTest.mm (right):

https://codereview.webrtc.org/1616363005/diff/1/webrtc/api/objctests/RTCDataC...
webrtc/api/objctests/RTCDataChannelConfigurationTest.mm:29:
dataChannelConfig.maxPacketLifeTime = 5;
consider using one variable for both setting the config and checking its value.

[hjon_webrtc, 2016-01-27 18:38:36]

@tkchin This is what you were thinking, right?

https://codereview.webrtc.org/1616363005/diff/1/webrtc/api/objctests/RTCDataC...
File webrtc/api/objctests/RTCDataChannelConfigurationTest.mm (right):

https://codereview.webrtc.org/1616363005/diff/1/webrtc/api/objctests/RTCDataC...
webrtc/api/objctests/RTCDataChannelConfigurationTest.mm:29:
dataChannelConfig.maxPacketLifeTime = 5;
On 2016/01/26 20:12:43, tkchin_webrtc wrote:
> consider using one variable for both setting the config and checking its
value.

Done.

[tkchin_webrtc, 2016-01-27 18:44:59]

yup

[tkchin_webrtc, 2016-01-27 18:44:59]

yup

[tkchin_webrtc, 2016-01-27 18:45:34]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-01-27 18:45:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1616363005/#ps20001 (title:
"Changes based on feedback")

[commit-bot: I haz the power, 2016-01-27 18:45:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616363005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616363005/20001

[commit-bot: I haz the power, 2016-01-27 19:42:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 19:42:01]

Try jobs failed on following builders:
  linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)

[hjon_webrtc, 2016-01-27 21:11:48]

The CQ bit was checked by hjon@webrtc.org

[commit-bot: I haz the power, 2016-01-27 21:11:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616363005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616363005/20001

[commit-bot: I haz the power, 2016-01-27 21:42:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-27 21:42:43]

Description was changed from

==========
Update API for Objective-C RTCDataChannelConfiguration.

BUG=
==========

to

==========
Update API for Objective-C RTCDataChannelConfiguration.

BUG=

Committed: https://crrev.com/da2183c86fcdf4cd525ea4cdc63bd3ba95703291
Cr-Commit-Position: refs/heads/master@{#11405}
==========

[commit-bot: I haz the power, 2016-01-27 21:42:49]

Patchset 2 (id:??) landed as
https://crrev.com/da2183c86fcdf4cd525ea4cdc63bd3ba95703291
Cr-Commit-Position: refs/heads/master@{#11405}