Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1616273004: Revert "Disable P2PTransport...TestFailoverControlledSide on Memcheck" (Closed)

Created:
4 years, 11 months ago by tnakamura-webrtc
Modified:
4 years, 11 months ago
Reviewers:
honghaiz3
CC:
webrtc-reviews_webrtc.org, hlundin-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Disable P2PTransport...TestFailoverControlledSide on Memcheck" This reverts commit 1a8240c32a14a31b1417b6e06f511f2a16d81b19. Per comments in bug 5136, the affected test should no longer be flaky. BUG=webrtc:5136 Committed: https://crrev.com/cc71c4107ff0f2e5c4b8636bf71aa5de92fbbb47 Cr-Commit-Position: refs/heads/master@{#11360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
tnakamura-webrtc
4 years, 11 months ago (2016-01-22 19:26:55 UTC) #3
honghaiz3
lgtm
4 years, 11 months ago (2016-01-22 19:37:32 UTC) #4
honghaiz3
On 2016/01/22 19:37:32, honghaiz3 wrote: > lgtm Thanks for making this CL! Please change the ...
4 years, 11 months ago (2016-01-22 19:38:44 UTC) #5
tnakamura-webrtc
On 2016/01/22 19:38:44, honghaiz3 wrote: > On 2016/01/22 19:37:32, honghaiz3 wrote: > > lgtm > ...
4 years, 11 months ago (2016-01-22 19:42:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616273004/1
4 years, 11 months ago (2016-01-22 20:40:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 20:45:05 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 20:45:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc71c4107ff0f2e5c4b8636bf71aa5de92fbbb47
Cr-Commit-Position: refs/heads/master@{#11360}

Powered by Google App Engine
This is Rietveld 408576698