Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: webrtc/base/socket_unittest.h

Issue 1616153007: Stay writable after partial socket writes. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Tentative fix for Mac. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/socket_unittest.h
diff --git a/webrtc/base/socket_unittest.h b/webrtc/base/socket_unittest.h
index e4a6b327059d8098476356b717870145cfb93db9..43a53f5a5d0cfc96c52ae04c7cde08cfe6935d3d 100644
--- a/webrtc/base/socket_unittest.h
+++ b/webrtc/base/socket_unittest.h
@@ -62,6 +62,13 @@ class SocketTest : public testing::Test {
const IPAddress kIPv4Loopback;
const IPAddress kIPv6Loopback;
+ protected:
+ static const size_t kDefaultTcpInternalDataSize = 1024 * 1024; // bytes
+
+ void TcpInternal(const IPAddress& loopback,
+ size_t data_size = kDefaultTcpInternalDataSize,
+ size_t check_max_sent_size = kDefaultTcpInternalDataSize);
pthatcher1 2016/02/02 18:25:39 Actually, can you make these non-optional argument
joachim 2016/02/03 18:44:23 Done.
+
private:
void ConnectInternal(const IPAddress& loopback);
void ConnectWithDnsLookupInternal(const IPAddress& loopback,
@@ -76,7 +83,6 @@ class SocketTest : public testing::Test {
void ServerCloseInternal(const IPAddress& loopback);
void CloseInClosedCallbackInternal(const IPAddress& loopback);
void SocketServerWaitInternal(const IPAddress& loopback);
- void TcpInternal(const IPAddress& loopback);
void SingleFlowControlCallbackInternal(const IPAddress& loopback);
void UdpInternal(const IPAddress& loopback);
void UdpReadyToSend(const IPAddress& loopback);

Powered by Google App Engine
This is Rietveld 408576698