Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1616153005: Switch to use new implementation in metrics.h. (Closed)

Created:
4 years, 11 months ago by åsapersson
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Switch to use new implementation in metrics.h. Sparse macro replaced for all video histograms that have a constant name. BUG=webrtc:5283 Committed: https://crrev.com/28ba92731d695ca0dd12156afcedf32ea5881ccc Cr-Commit-Position: refs/heads/master@{#11368}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -90 lines) Patch
M webrtc/call/call.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/jitter_buffer.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/timing.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 chunk +11 lines, -12 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/video/vie_channel.cc View 6 chunks +34 lines, -43 lines 0 comments Download
M webrtc/video/vie_receiver.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
åsapersson
4 years, 11 months ago (2016-01-25 08:03:23 UTC) #3
pbos-webrtc
drive-by lgtm
4 years, 11 months ago (2016-01-25 10:50:52 UTC) #5
stefan-webrtc
lgtm
4 years, 11 months ago (2016-01-25 13:52:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616153005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616153005/20001
4 years, 11 months ago (2016-01-25 13:56:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 13:58:26 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 13:58:33 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28ba92731d695ca0dd12156afcedf32ea5881ccc
Cr-Commit-Position: refs/heads/master@{#11368}

Powered by Google App Engine
This is Rietveld 408576698