Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1615873002: Fix probing breakage with send-side BWE introduced by r11322. (Closed)

Created:
4 years, 11 months ago by stefan-webrtc
Modified:
4 years, 11 months ago
Reviewers:
sprang, sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix probing breakage with send-side BWE introduced by r11322. BUG=chromium:580046, webrtc:4173 Committed: https://crrev.com/fa156696dd0a73287da7c10ee071f74b9470a3fe Cr-Commit-Position: refs/heads/master@{#11344}

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc View 1 1 chunk +13 lines, -8 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc View 3 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
stefan-webrtc
4 years, 11 months ago (2016-01-21 14:21:46 UTC) #2
sprang
lgtm
4 years, 11 months ago (2016-01-21 14:25:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615873002/1
4 years, 11 months ago (2016-01-21 14:26:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/12231)
4 years, 11 months ago (2016-01-21 14:37:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615873002/20001
4 years, 11 months ago (2016-01-21 14:50:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 16:55:06 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 16:55:15 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fa156696dd0a73287da7c10ee071f74b9470a3fe
Cr-Commit-Position: refs/heads/master@{#11344}

Powered by Google App Engine
This is Rietveld 408576698