Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1615653009: Corrected bug in checking the third number and added extra checks (Closed)

Created:
4 years, 11 months ago by Dani Kirov
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Corrected bug in checking the third number and added extra checks for memory protection. BUG=webrtc:5454 Committed: https://crrev.com/f2eae333a2e42d20e92e7606bfca087fddcaaaa0 Cr-Commit-Position: refs/heads/master@{#12643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M webrtc/test/channel_transport/udp_transport_impl.cc View 4 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
braveyao1
stefan@, please help to take a look!
4 years, 11 months ago (2016-01-22 18:34:19 UTC) #2
stefan-webrtc
lgtm
4 years, 7 months ago (2016-05-06 10:59:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615653009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615653009/1
4 years, 7 months ago (2016-05-06 10:59:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 13:12:24 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 13:12:35 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f2eae333a2e42d20e92e7606bfca087fddcaaaa0
Cr-Commit-Position: refs/heads/master@{#12643}

Powered by Google App Engine
This is Rietveld 408576698