Change PeerConnectionFactory.setVideoHwAccelerationOptions to create shared Egl context for harware…

Change PeerConnectionFactory.setVideoHwAccelerationOptions to create shared Egl context for harware encoders and decoders.
Before this fix, it was required that the EGL context used as an argument was kept open until all PeerConnections using the context had been closed. With this fix, that is no longer required.
Also, if a released EGLContext (EGL_NO_CONTEXT) is used, harware codecs will fallback to use byte buffers for encoding and decoding.
BUG=b/26583522
R=glaznev@webrtc.org

Committed: https://crrev.com/ec2922f86437f88a4a72292696b8b1a3fa133d0d
Cr-Commit-Position: refs/heads/master@{#11398}

[perkj_webrtc, 2016-01-21 21:00:17]

Patchset #1 (id:1) has been deleted

[perkj_webrtc, 2016-01-21 21:05:23]

perkj@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[perkj_webrtc, 2016-01-21 21:05:23]

Something like this...

[AlexG, 2016-01-26 01:04:26]

On 2016/01/21 21:05:23, perkj_webrtc wrote:
> Something like this...

May be a little easier solution is to create copy of EGL context directly in
Java - in PeerConnectionFactory.setVideoHwAccelerationOptions and add a function
to release this new shared context once call is done - like
PeerConnectionFactory.resetVideoHwAccelerationOption()? This reset/release call
can be done after PeerConnectionClient.dispose() call when can be sure that
MediaCodec factories are released?

[perkj_webrtc, 2016-01-26 10:00:35]

On 2016/01/26 01:04:26, AlexG wrote:
> On 2016/01/21 21:05:23, perkj_webrtc wrote:
> > Something like this...
> 
> May be a little easier solution is to create copy of EGL context directly in
> Java - in PeerConnectionFactory.setVideoHwAccelerationOptions and add a
function
> to release this new shared context once call is done - like
> PeerConnectionFactory.resetVideoHwAccelerationOption()? This reset/release
call
> can be done after PeerConnectionClient.dispose() call when can be sure that
> MediaCodec factories are released?

That would be nice but how can I do that in Java as long as we support Java that
is not Android? I would not mind skipping "normal java" support and have
everything in PeerConnectionFactory to be Android specific.
I think most of these changes make sence regardless. With your suggestion- we
would not need eglbase_jni.h and cc which of course is a good thing.

[AlexG, 2016-01-26 19:46:14]

On 2016/01/26 10:00:35, perkj_webrtc wrote:
> On 2016/01/26 01:04:26, AlexG wrote:
> > On 2016/01/21 21:05:23, perkj_webrtc wrote:
> > > Something like this...
> > 
> > May be a little easier solution is to create copy of EGL context directly in
> > Java - in PeerConnectionFactory.setVideoHwAccelerationOptions and add a
> function
> > to release this new shared context once call is done - like
> > PeerConnectionFactory.resetVideoHwAccelerationOption()? This reset/release
> call
> > can be done after PeerConnectionClient.dispose() call when can be sure that
> > MediaCodec factories are released?
> 
> That would be nice but how can I do that in Java as long as we support Java
that
> is not Android? I would not mind skipping "normal java" support and have
> everything in PeerConnectionFactory to be Android specific.
> I think most of these changes make sence regardless. With your suggestion- we
> would not need eglbase_jni.h and cc which of course is a good thing.

lgtm

Ah right.
May be then adding abstract EGLBase to org.webrtc and making two implementations
- one for Android and another empty - for Linux. But I guess it will be same
complexity as current solution.

[perkj_webrtc, 2016-01-27 09:05:56]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-01-27 09:06:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615153002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615153002/60001

[commit-bot: I haz the power, 2016-01-27 10:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 10:08:16]

Try jobs failed on following builders:
  linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)

[perkj_webrtc, 2016-01-27 14:26:01]

Description was changed from

==========
Change PeerConnectionFactory.setVideoHwAccelerationOptions to create shared Egl
context for harware encoders and decoders.
Before this fix, it was required that the EGL context used as an argument was
kept open until all PeerConnections using the context had been closed. With this
fix, that is no longer required.
Also, if a released EGLContext (EGL_NO_CONTEXT) is used, harware codecs will
fallback to use byte buffers for encoding and decoding.
BUG=b/26583522
==========

to

==========
Change PeerConnectionFactory.setVideoHwAccelerationOptions to create shared Egl
context for harware encoders and decoders.
Before this fix, it was required that the EGL context used as an argument was
kept open until all PeerConnections using the context had been closed. With this
fix, that is no longer required.
Also, if a released EGLContext (EGL_NO_CONTEXT) is used, harware codecs will
fallback to use byte buffers for encoding and decoding.
BUG=b/26583522
R=glaznev@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ec2922f86437f88a4a7229269...
==========

[perkj_webrtc, 2016-01-27 14:26:02]

Committed patchset #3 (id:60001) manually as
ec2922f86437f88a4a72292696b8b1a3fa133d0d (presubmit successful).

[commit-bot: I haz the power, 2016-01-27 14:26:05]

Description was changed from

==========
Change PeerConnectionFactory.setVideoHwAccelerationOptions to create shared Egl
context for harware encoders and decoders.
Before this fix, it was required that the EGL context used as an argument was
kept open until all PeerConnections using the context had been closed. With this
fix, that is no longer required.
Also, if a released EGLContext (EGL_NO_CONTEXT) is used, harware codecs will
fallback to use byte buffers for encoding and decoding.
BUG=b/26583522
R=glaznev@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ec2922f86437f88a4a7229269...
==========

to

==========
Change PeerConnectionFactory.setVideoHwAccelerationOptions to create shared Egl
context for harware encoders and decoders.
Before this fix, it was required that the EGL context used as an argument was
kept open until all PeerConnections using the context had been closed. With this
fix, that is no longer required.
Also, if a released EGLContext (EGL_NO_CONTEXT) is used, harware codecs will
fallback to use byte buffers for encoding and decoding.
BUG=b/26583522
R=glaznev@webrtc.org

Committed: https://crrev.com/ec2922f86437f88a4a72292696b8b1a3fa133d0d
Cr-Commit-Position: refs/heads/master@{#11398}
==========

[commit-bot: I haz the power, 2016-01-27 14:26:06]

Patchset 3 (id:??) landed as
https://crrev.com/ec2922f86437f88a4a72292696b8b1a3fa133d0d
Cr-Commit-Position: refs/heads/master@{#11398}