Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1614373002: Remove implementation of CriticalSectionWrapper and use rtc::CriticalSection (Closed)

Created:
4 years, 11 months ago by tommi
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove implementation of CriticalSectionWrapper and use rtc::CriticalSection While transitioning over to rtc::CriticalSection completely, this gives perf benefits that rtc::CriticalSection has on Mac to current users of CriticalSectionWrapper. BUG= Committed: https://crrev.com/5447934728080aab01e1c0c521aa71e9891320e5 Cr-Commit-Position: refs/heads/master@{#11356}

Patch Set 1 #

Patch Set 2 : Fix impl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -84 lines) Patch
M webrtc/system_wrappers/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/include/critical_section_wrapper.h View 1 2 chunks +11 lines, -22 lines 0 comments Download
D webrtc/system_wrappers/source/critical_section.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
tommi
4 years, 11 months ago (2016-01-22 07:52:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614373002/1
4 years, 11 months ago (2016-01-22 07:53:06 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios32_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/4698) ios_arm64_dbg on ...
4 years, 11 months ago (2016-01-22 07:54:45 UTC) #6
tommi
Fix impl
4 years, 11 months ago (2016-01-22 07:55:12 UTC) #7
tommi
4 years, 11 months ago (2016-01-22 12:29:35 UTC) #9
torbjorng (webrtc)
lgtm
4 years, 11 months ago (2016-01-22 12:57:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614373002/20001
4 years, 11 months ago (2016-01-22 13:07:11 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 13:26:17 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5447934728080aab01e1c0c521aa71e9891320e5 Cr-Commit-Position: refs/heads/master@{#11356}
4 years, 11 months ago (2016-01-22 13:26:25 UTC) #15
pbos-webrtc
4 years, 11 months ago (2016-01-22 15:21:23 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698