Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1613833003: Add new NetEq resources to modules_unittests.isolate. (Closed)

Created:
4 years, 11 months ago by kjellander_webrtc
Modified:
4 years, 11 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add new NetEq resources to modules_unittests.isolate. This should have been done in https://codereview.webrtc.org/1515113002 but was not detected since the test doesn't run on Android. BUG=chromium:497757 NOTRY=True TBR=minyue@webrtc.org Committed: https://crrev.com/1f150b35f89ad6b6ec7bb7d38996421562077ec6 Cr-Commit-Position: refs/heads/master@{#11334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/modules/modules_unittests.isolate View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kjellander_webrtc
Since I'm going to start working on Swarming test execution now, this needs to be ...
4 years, 11 months ago (2016-01-21 12:41:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613833003/1
4 years, 11 months ago (2016-01-21 12:41:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 12:42:25 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1f150b35f89ad6b6ec7bb7d38996421562077ec6 Cr-Commit-Position: refs/heads/master@{#11334}
4 years, 11 months ago (2016-01-21 12:42:33 UTC) #10
minyue-webrtc
4 years, 11 months ago (2016-01-21 13:06:20 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698