Issue 1613433002: Remove SendStreamFormat and ViewRequests.

Issue 1613433002: Remove SendStreamFormat and ViewRequests. (Closed)

Created:
4 years, 11 months ago by pbos-webrtc

Modified:
4 years, 10 months ago

Reviewers:
sophiechang-webrtc, pthatcher1

CC:
webrtc-reviews_webrtc.org

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Remove SendStreamFormat and ViewRequests. SendStreamFormat is broken in current implementation and ApplyViewRequest is no longer in use. BUG= R=pthatcher@webrtc.org, sophiechang@chromium.org Committed: https://crrev.com/ce23bee697842afb9eef230a07e935527a46a646 Cr-Commit-Position: refs/heads/master@{#11459}

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -280 lines)			Patch
M	talk/media/base/fakemediaengine.h	View	1	4 chunks	+1 line, -35 lines	0 comments	Download
M	talk/media/base/mediachannel.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	talk/media/base/streamparams.h	View		1 chunk	+0 lines, -25 lines	0 comments	Download
M	talk/media/base/videoengine_unittest.h	View	1	4 chunks	+0 lines, -65 lines	0 comments	Download
M	talk/media/webrtc/webrtcvideoengine2.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	talk/media/webrtc/webrtcvideoengine2.cc	View	1	2 chunks	+0 lines, -37 lines	0 comments	Download
M	talk/media/webrtc/webrtcvideoengine2_unittest.cc	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	talk/session/media/channel.h	View	1	3 chunks	+0 lines, -3 lines	0 comments	Download
M	talk/session/media/channel.cc	View	1	2 chunks	+0 lines, -41 lines	0 comments	Download
M	talk/session/media/channel_unittest.cc	View		1 chunk	+0 lines, -61 lines	0 comments	Download

Total messages: 11 (4 generated)

pbos-webrtc

PTAL pthatcher@, Sophie will review once this is ready to land.

4 years, 10 months ago (2016-01-27 15:47:24 UTC) #4

sophiechang-webrtc

On 2016/01/27 20:57:59, pthatcher1 wrote: > lgtm lgtm - should be good now :)

4 years, 10 months ago (2016-02-01 23:32:57 UTC) #6

pbos-webrtc

Committed patchset #2 (id:20001) manually as ce23bee697842afb9eef230a07e935527a46a646 (presubmit successful).

4 years, 10 months ago (2016-02-02 13:16:16 UTC) #10

commit-bot: I haz the power

4 years, 10 months ago (2016-02-02 13:16:16 UTC) #11

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/ce23bee697842afb9eef230a07e935527a46a646
Cr-Commit-Position: refs/heads/master@{#11459}