Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1613013002: Remove non-monotonic clock support (Closed)

Created:
4 years, 11 months ago by sprang_webrtc
Modified:
4 years, 11 months ago
Reviewers:
sprang, tommi, pbos-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove non-monotonic clock support Real time clock may cause problems as they can move (even backwards) if the clock is changed, eg updated by NTP. Non-monotonic clocks still in use on some platform (I'm looking at you, Apple) for timed waits, but that should be less of an issue than actual timestamps. BUG=webrtc:5452 Committed: https://crrev.com/e791ffd63873739b47a2633531f4ac2f12e6951d Cr-Commit-Position: refs/heads/master@{#11375}

Patch Set 1 #

Patch Set 2 : EventWrapper fix for Android #

Patch Set 3 : s/OS_ANDROID/WEBRTC_ANDROID #

Patch Set 4 : No monotonic timer for mac #

Patch Set 5 : Debug print WIP #

Patch Set 6 : Even more debug tracing #

Patch Set 7 : Rebase, fix dumb copy/past error #

Patch Set 8 : Cleanup #

Total comments: 2

Patch Set 9 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -48 lines) Patch
M webrtc/base/platform_thread.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 3 chunks +3 lines, -19 lines 0 comments Download
M webrtc/system_wrappers/source/event_timer_posix.cc View 1 2 3 4 5 6 7 5 chunks +19 lines, -14 lines 0 comments Download
M webrtc/system_wrappers/source/tick_util.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers.gyp View 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
pbos-webrtc
+R tommi@, since this is a big across-the-everything change, do you have any concerns?
4 years, 11 months ago (2016-01-21 15:49:50 UTC) #5
tommi
is there a bug with some more information? I can rs the change but I ...
4 years, 11 months ago (2016-01-21 16:05:32 UTC) #6
sprang_webrtc
There is indeed a bug linked, as discussed offline as well. Should be in a ...
4 years, 11 months ago (2016-01-25 18:59:52 UTC) #8
tommi
lgtm % remove the below log https://codereview.webrtc.org/1613013002/diff/140001/webrtc/video/video_capture_input.cc File webrtc/video/video_capture_input.cc (right): https://codereview.webrtc.org/1613013002/diff/140001/webrtc/video/video_capture_input.cc#newcode53 webrtc/video/video_capture_input.cc:53: LOG(LS_WARNING) << "delta_ntp_internal_ms_ ...
4 years, 11 months ago (2016-01-25 19:20:49 UTC) #9
sprang_webrtc
https://codereview.webrtc.org/1613013002/diff/140001/webrtc/video/video_capture_input.cc File webrtc/video/video_capture_input.cc (right): https://codereview.webrtc.org/1613013002/diff/140001/webrtc/video/video_capture_input.cc#newcode53 webrtc/video/video_capture_input.cc:53: LOG(LS_WARNING) << "delta_ntp_internal_ms_ = " << delta_ntp_internal_ms_; On 2016/01/25 ...
4 years, 11 months ago (2016-01-25 19:34:18 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613013002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613013002/160001
4 years, 11 months ago (2016-01-25 19:34:32 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 20:57:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613013002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613013002/160001
4 years, 11 months ago (2016-01-26 09:51:40 UTC) #17
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 11 months ago (2016-01-26 09:53:23 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 09:53:34 UTC) #21
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/e791ffd63873739b47a2633531f4ac2f12e6951d
Cr-Commit-Position: refs/heads/master@{#11375}

Powered by Google App Engine
This is Rietveld 408576698