Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1612713002: Remove RentACodec::GetEncoderStack (Closed)

Created:
4 years, 11 months ago by kwiberg-webrtc
Modified:
4 years, 11 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove RentACodec::GetEncoderStack Callers can just remember the return value of RentACodec::RentEncoderStack instead. BUG=webrtc:5028 Committed: https://crrev.com/32be07bc36813d351c3555c502a819d3dd172d07 Cr-Commit-Position: refs/heads/master@{#11340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -48 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 19 chunks +31 lines, -34 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
4 years, 11 months ago (2016-01-21 01:06:37 UTC) #3
hlundin-webrtc
lgtm
4 years, 11 months ago (2016-01-21 15:05:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612713002/1
4 years, 11 months ago (2016-01-21 15:08:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 15:10:04 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 15:10:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32be07bc36813d351c3555c502a819d3dd172d07
Cr-Commit-Position: refs/heads/master@{#11340}

Powered by Google App Engine
This is Rietveld 408576698