Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1612053002: Fix a bug in InputAudioFile::Read (Closed)

Created:
4 years, 11 months ago by hlundin-webrtc
Modified:
4 years, 11 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a bug in InputAudioFile::Read When the file was rewound, the remaining audio read was inserted at the start of the destination array, not where the first reading attempt ended. R=ivoc@webrtc.org Committed: https://crrev.com/fea3dd83fcb734ee1c4fb079bb22aa74093254d6 Cr-Commit-Position: refs/heads/master@{#11343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/audio_coding/neteq/tools/input_audio_file.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hlundin-webrtc
Ivo, please, take a look. Thanks!
4 years, 11 months ago (2016-01-21 14:28:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612053002/1
4 years, 11 months ago (2016-01-21 14:28:29 UTC) #3
ivoc
lgtm!
4 years, 11 months ago (2016-01-21 14:33:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612053002/1
4 years, 11 months ago (2016-01-21 14:34:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 16:20:01 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 16:20:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fea3dd83fcb734ee1c4fb079bb22aa74093254d6
Cr-Commit-Position: refs/heads/master@{#11343}

Powered by Google App Engine
This is Rietveld 408576698