Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1611223002: Make rtc::CriticalSection lockable from f() const. (Closed)

Created:
4 years, 11 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, peah-webrtc, andresp, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, the sun, pbos-webrtc, perkj_webrtc, aluebs-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make rtc::CriticalSection lockable from f() const. Removes the use of mutable rtc::CriticalSection across the code. BUG= R=tommi@webrtc.org Committed: https://crrev.com/af9e6637c0fd154a6469a07913e233aad2b4d8f0 Cr-Commit-Position: refs/heads/master@{#11342}

Patch Set 1 #

Patch Set 2 : make change first #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M webrtc/base/criticalsection.h View 1 2 4 chunks +14 lines, -11 lines 0 comments Download
M webrtc/base/criticalsection.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pbos-webrtc
make change first
4 years, 11 months ago (2016-01-21 15:34:44 UTC) #1
tommi
lgtm % request https://codereview.webrtc.org/1611223002/diff/20001/webrtc/base/criticalsection.h File webrtc/base/criticalsection.h (right): https://codereview.webrtc.org/1611223002/diff/20001/webrtc/base/criticalsection.h#newcode49 webrtc/base/criticalsection.h:49: void Enter() const EXCLUSIVE_LOCK_FUNCTION(); can you ...
4 years, 11 months ago (2016-01-21 15:39:36 UTC) #2
pbos-webrtc
comment
4 years, 11 months ago (2016-01-21 15:41:25 UTC) #3
pbos-webrtc
https://codereview.webrtc.org/1611223002/diff/20001/webrtc/base/criticalsection.h File webrtc/base/criticalsection.h (right): https://codereview.webrtc.org/1611223002/diff/20001/webrtc/base/criticalsection.h#newcode49 webrtc/base/criticalsection.h:49: void Enter() const EXCLUSIVE_LOCK_FUNCTION(); On 2016/01/21 15:39:36, tommi-webrtc wrote: ...
4 years, 11 months ago (2016-01-21 15:41:32 UTC) #4
pbos-webrtc
Committed patchset #3 (id:40001) manually as af9e6637c0fd154a6469a07913e233aad2b4d8f0 (presubmit successful).
4 years, 11 months ago (2016-01-21 15:57:08 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 15:57:08 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/af9e6637c0fd154a6469a07913e233aad2b4d8f0
Cr-Commit-Position: refs/heads/master@{#11342}

Powered by Google App Engine
This is Rietveld 408576698