Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: webrtc/call/bitrate_allocator.h

Issue 1610553002: Switch use of CriticalSectionWrapper -> rtc::CriticalSection in call/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/call/bitrate_allocator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 * 9 *
10 * Usage: this class will register multiple RtcpBitrateObserver's one at each 10 * Usage: this class will register multiple RtcpBitrateObserver's one at each
11 * RTCP module. It will aggregate the results and run one bandwidth estimation 11 * RTCP module. It will aggregate the results and run one bandwidth estimation
12 * and push the result to the encoders via BitrateObserver(s). 12 * and push the result to the encoders via BitrateObserver(s).
13 */ 13 */
14 14
15 #ifndef WEBRTC_CALL_BITRATE_ALLOCATOR_H_ 15 #ifndef WEBRTC_CALL_BITRATE_ALLOCATOR_H_
16 #define WEBRTC_CALL_BITRATE_ALLOCATOR_H_ 16 #define WEBRTC_CALL_BITRATE_ALLOCATOR_H_
17 17
18 #include <list> 18 #include <list>
19 #include <map> 19 #include <map>
20 #include <utility> 20 #include <utility>
21 21
22 #include "webrtc/base/criticalsection.h"
22 #include "webrtc/base/scoped_ptr.h" 23 #include "webrtc/base/scoped_ptr.h"
23 #include "webrtc/base/thread_annotations.h" 24 #include "webrtc/base/thread_annotations.h"
24 #include "webrtc/system_wrappers/include/critical_section_wrapper.h"
25 25
26 namespace webrtc { 26 namespace webrtc {
27 27
28 class BitrateObserver; 28 class BitrateObserver;
29 29
30 class BitrateAllocator { 30 class BitrateAllocator {
31 public: 31 public:
32 BitrateAllocator(); 32 BitrateAllocator();
33 33
34 // Allocate target_bitrate across the registered BitrateObservers. 34 // Allocate target_bitrate across the registered BitrateObservers.
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 BitrateObserverConfList::iterator FindObserverConfigurationPair( 82 BitrateObserverConfList::iterator FindObserverConfigurationPair(
83 const BitrateObserver* observer) EXCLUSIVE_LOCKS_REQUIRED(crit_sect_); 83 const BitrateObserver* observer) EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
84 ObserverBitrateMap AllocateBitrates() EXCLUSIVE_LOCKS_REQUIRED(crit_sect_); 84 ObserverBitrateMap AllocateBitrates() EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
85 ObserverBitrateMap NormalRateAllocation(uint32_t bitrate, 85 ObserverBitrateMap NormalRateAllocation(uint32_t bitrate,
86 uint32_t sum_min_bitrates) 86 uint32_t sum_min_bitrates)
87 EXCLUSIVE_LOCKS_REQUIRED(crit_sect_); 87 EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
88 88
89 ObserverBitrateMap LowRateAllocation(uint32_t bitrate) 89 ObserverBitrateMap LowRateAllocation(uint32_t bitrate)
90 EXCLUSIVE_LOCKS_REQUIRED(crit_sect_); 90 EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
91 91
92 rtc::scoped_ptr<CriticalSectionWrapper> crit_sect_; 92 mutable rtc::CriticalSection crit_sect_;
93 // Stored in a list to keep track of the insertion order. 93 // Stored in a list to keep track of the insertion order.
94 BitrateObserverConfList bitrate_observers_ GUARDED_BY(crit_sect_); 94 BitrateObserverConfList bitrate_observers_ GUARDED_BY(crit_sect_);
95 bool bitrate_observers_modified_ GUARDED_BY(crit_sect_); 95 bool bitrate_observers_modified_ GUARDED_BY(crit_sect_);
96 bool enforce_min_bitrate_ GUARDED_BY(crit_sect_); 96 bool enforce_min_bitrate_ GUARDED_BY(crit_sect_);
97 uint32_t last_bitrate_bps_ GUARDED_BY(crit_sect_); 97 uint32_t last_bitrate_bps_ GUARDED_BY(crit_sect_);
98 uint8_t last_fraction_loss_ GUARDED_BY(crit_sect_); 98 uint8_t last_fraction_loss_ GUARDED_BY(crit_sect_);
99 int64_t last_rtt_ GUARDED_BY(crit_sect_); 99 int64_t last_rtt_ GUARDED_BY(crit_sect_);
100 }; 100 };
101 } // namespace webrtc 101 } // namespace webrtc
102 #endif // WEBRTC_CALL_BITRATE_ALLOCATOR_H_ 102 #endif // WEBRTC_CALL_BITRATE_ALLOCATOR_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/call/bitrate_allocator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698